Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Lin_domain.stress_test #443

Merged
merged 16 commits into from
Mar 20, 2024
Merged

Add Lin_domain.stress_test #443

merged 16 commits into from
Mar 20, 2024

Conversation

jmid
Copy link
Collaborator

@jmid jmid commented Mar 19, 2024

This PR adds Lin_domain.stress_{prop,test}
These are useful to test that parallel misuse does not cause any crashes.

For the testsuite we add stress tests of modules containing only negative parallel tests, that tend to find a counterexample fast, and hence not perform much parallel stress testing.

While experimenting with the branch, this mode has already been useful to help create a consistent reproducer of the Dynlink issue #307.

I tried cleaning up the git-history this time, so it should read relatively cleanly @shym 😉
Can you give it a brief look, e.g., just the first 4 commits?

@jmid
Copy link
Collaborator Author

jmid commented Mar 20, 2024

CI summary:

The two MinGW failures nicely makes the case for this PR 🎉

Out of 35 workflows 5 failed with 3 genuine issues and 2 CI issues

Copy link
Collaborator

@shym shym left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM: the only thing I have to suggest would be to squash the first two commits together.
Otherwise, it is very nice to read, thank you!

@jmid jmid merged commit fc06cf7 into main Mar 20, 2024
21 of 25 checks passed
@jmid jmid deleted the lin-stress-mode branch March 20, 2024 15:35
@jmid
Copy link
Collaborator Author

jmid commented Mar 22, 2024

CI summary for merge to main:

Out of 36 workflows 6 failed with 4 genuine issues and 2 internal multicoretests-ci failures

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants