Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While trying out a run of
multicoretests
under TSan, I spotted some limitations of ourSTM
Semaphore
tests.For one, we test
Semaphore.Counting.get_value
in parallel despite it being documented as racy.This PR
STM
Semaphore.Counting
test that excludesget_value
Semaphore.Binary
STM
test for completenessBecause of the precondition in the
Semaphore.Binary
STM
test, it needs to generate extra inputs.By default,
qcheck-stm
tries to generate up to 3x as many inputs as needed which is not quite enough to hit 500:The test is still relatively fast with a count of 500 compared to the
STM
Semaphore.Counting
testwhich has a count of 200:
As such I'm leaning towards declaring good enough...