-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chore: Lin DSL test renaming #408
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I just restarted a bunch of jobs as roughly 1/2 of the GitHub actions workflows failed after seconds, due to some internal glitch I suppose. The restarted runs seem to progress fine though. |
CI summary:
Out of 63 workflows (incl. 10 opam install ones) 5 failed, of which 4 were genuine and 1 was a borderline case |
CI summary for merge to
Out of 38 workflows, 1 failed - with a genuine failure |
This was referenced Nov 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is the sister PR to #396, eliminating historical occurrences of
DSL
anddsl
in file and test names.Together, the effect of the two PRs is the following renaming:
The
DSL
name is historic and was eliminated before our initial opam package release.As
Lin
is the primary user-facing library for sequential consistency testing, I think this is preferable.It should be more intuitive to locate the right test with these names.
If done right, the PR should have no effect on test suite functionality... (I'm already seeing lots of weird red CI lights though! 😬 )
While at it, I also spotted a few tests that were missing from the overview in
src/README.md
.