Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create a multicore-magic-dscheck library #16

Merged
merged 9 commits into from
Jul 10, 2024
Merged

Create a multicore-magic-dscheck library #16

merged 9 commits into from
Jul 10, 2024

Conversation

lyrm
Copy link
Contributor

@lyrm lyrm commented Jun 25, 2024

Work in progress, I need to check this is actually working !

@lyrm lyrm marked this pull request as draft June 25, 2024 16:41
@lyrm lyrm force-pushed the dscheck_atomic_array branch 2 times, most recently from b729933 to 02fa833 Compare July 2, 2024 16:04
@lyrm lyrm marked this pull request as ready for review July 2, 2024 16:18
polytypic
polytypic reviewed Jul 4, 2024
View reviewed changes
src/dscheck/dune Outdated Show resolved Hide resolved
polytypic
polytypic reviewed Jul 4, 2024
View reviewed changes
dune-project Outdated Show resolved Hide resolved
polytypic
polytypic reviewed Jul 4, 2024
View reviewed changes
dune-project Outdated Show resolved Hide resolved
@lyrm lyrm force-pushed the dscheck_atomic_array branch from b25fec9 to e7f16b2 Compare July 4, 2024 14:21
@lyrm
Copy link
Contributor Author

lyrm commented Jul 4, 2024

I rebased and applied your review. Thanks !

polytypic
polytypic approved these changes Jul 4, 2024
View reviewed changes
Copy link
Collaborator

@polytypic polytypic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We still need to get rid of the pin-depends before merging, but otherwise this looks good, so I'm marking this as approved. 👍

Thanks for the contribution!

@polytypic
Copy link
Collaborator

Thanks! I'll merge this and publish a new version on opam.

@polytypic polytypic merged commit 4012b1a into ocaml-multicore:main Jul 10, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@polytypic polytypic polytypic approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lyrm @polytypic