Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An attempt at improving the test coverage:
Currently this is all a bit cheap! The program generator could produce more interesting logic. The random sampling is also super naïve since it favors "easy to find" outcomes, but that seems exhaustive enough at the moment (since dscheck rarely discovers more endings, the programs are too simple to hide anything).
I initially wrote this to test #3 but haven't found any bugs yet. I did confirm that it would have found the issues in the previous version of this PR :) What I did not expect is that it also produces broken programs on
main
, I thought this branch was super exhaustive and rock solid. I've extracted the buggy cases in a new testsuite if someone wants to take a look, it's a bit weird.