-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
parallel_find : ... -> (unit -> 'a option) -> 'a option #90
Conversation
The CI failures comes from my use of |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! parallel_find
is certainly useful to have. The code looks good to me, and the docs capture the expected behaviour well.
You're right about the CI, updating to beta should fix the failure -- I was planning on doing it soon, that shouldn't block this PR.
Suggested-by: Christophe Raffali <[email protected]> Reviewed-by: Sudha Parimala <[email protected]>
Thanks for sharing @ElectreAAS. While we may want to add a full fledged cancellation mechanism (for e.g. like the one in Eio) at a later point, this is a useful feature to have at present. The CI failure looks unrelated, and the branch works fine on my local setup. Merging. |
CHANGES: * Add parallel_find (ocaml-multicore/domainslib#90, @gasche) * Update CI (ocaml-multicore/domainslib#93, @Sudha247) * Optimisation to work-stealing (ocaml-multicore/domainslib#96, @art-w) * Improve docs presentation (ocaml-multicore/domainslib#99, @metanivek) * Property based tests (ocaml-multicore/domainslib#100, jmid) * Task: avoid double handler installation (ocaml-multicore/domainslib#101, @gasche & @clef-men) * Fix a benign data-race in Chan reported by ocaml-tsan (ocaml-multicore/domainslib#103, @art-w) * Dune, opam, and GitHub Actions fixes (ocaml-multicore/domainslib#105, @MisterDA) * domain local await support (ocaml-multicore/domainslib#107, @polytypic) * Windows run on GitHub Actions (ocaml-multicore/domainslib#110, @Sudha247) * Adjust PBTs based on recommended_domain_count (ocaml-multicore/domainslib#112, @jmid) * Test condition tweaks (ocaml-multicore/domainslib#113, @jmid)
CHANGES: * Add parallel_find (ocaml-multicore/domainslib#90, @gasche) * Update CI (ocaml-multicore/domainslib#93, @Sudha247) * Optimisation to work-stealing (ocaml-multicore/domainslib#96, @art-w) * Improve docs presentation (ocaml-multicore/domainslib#99, @metanivek) * Property based tests (ocaml-multicore/domainslib#100, jmid) * Task: avoid double handler installation (ocaml-multicore/domainslib#101, @gasche & @clef-men) * Fix a benign data-race in Chan reported by ocaml-tsan (ocaml-multicore/domainslib#103, @art-w) * Dune, opam, and GitHub Actions fixes (ocaml-multicore/domainslib#105, @MisterDA) * domain local await support (ocaml-multicore/domainslib#107, @polytypic) * Windows run on GitHub Actions (ocaml-multicore/domainslib#110, @Sudha247) * Adjust PBTs based on recommended_domain_count (ocaml-multicore/domainslib#112, @jmid) * Test condition tweaks (ocaml-multicore/domainslib#113, @jmid)
This is proposed as a solution for #89.