Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dune switch [do not merge] #13

Open
wants to merge 20 commits into
base: master
Choose a base branch
from
Open

Dune switch [do not merge] #13

wants to merge 20 commits into from

Conversation

UnixJunkie
Copy link
Collaborator

If we do this, then it compiles with dune, but all the tests and examples fail like

File "/home/berenger/src/ocamlscript/tests/./unpack", line 9, characters 0-26:
Error: Unbound module Ocamlscript

Hence the [do not merge].

@UnixJunkie
deleted: pa_opt310.ml
e4805b4
@UnixJunkie
rm trailing whitespaces
4f3a15d
@UnixJunkie
Pipeline: indent whole file
0eb7352 
plus add missing '|' on each first pattern matched
@UnixJunkie
Main: indent whole file
d526fc6 
add missing '|' on first pattern matched
@UnixJunkie
Ocaml: indent whole file
84c60f3 
add missing '|' character on first pattern matched
@UnixJunkie
new file: src/version.ml
d9eb7d6
@UnixJunkie
renamed: common.ml -> src/common.ml
5a54ec8 
renamed:    common.mli -> src/common.mli
renamed:    ocaml.ml -> src/ocaml.ml
renamed:    ocaml.mli -> src/ocaml.mli
renamed:    pipeline.ml -> src/pipeline.ml
renamed:    pipeline.mli -> src/pipeline.mli
renamed:    std.ml -> src/std.ml
renamed:    utils.ml -> src/utils.ml
renamed:    utils.mli -> src/utils.mli
@UnixJunkie
renamed: main.ml -> src/main.ml
050b753
@UnixJunkie
renamed: src/main.ml -> src/ocamlscript.ml
e59b0ac
@UnixJunkie
dune forces us to have a version.mli file ?!
703c44f
@UnixJunkie
created dune files
360189c
@UnixJunkie
opam: impacted by switch to dune
953e9dc
@UnixJunkie
compile with dune
2533275 
needed to make unused vars explicit
@UnixJunkie
dune: only give public_name for the exe
d87b216 
so that dune knows it must be installed
@UnixJunkie
mv opam ocamlscript.opam
e208f4d
@UnixJunkie
mv opam ocamlscript.opam
2d44efe
@UnixJunkie
updated tests/Makefile
21038c5
@UnixJunkie
dune: apparently, we need a library plus an exe
a11de98
@UnixJunkie
calling Ocamlscript.main() was moved to the new src/main.ml file
6b1c150 
dune requirement, apparently, since from one module we create
both an exe and a library
@UnixJunkie
updated makefiles to call the freshly compiled by dune exe
bc58ce8
@UnixJunkie
Copy link
Collaborator Author

related to #7

@UnixJunkie UnixJunkie mentioned this pull request Oct 1, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
help-wanted
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@UnixJunkie