Add AIMMO_DJANGO_BASE_URL to settings #310
Conversation
There was a problem hiding this comment.
Reviewed 1 of 3 files at r1, all commit messages.
Reviewable status: 1 of 3 files reviewed, 2 unresolved discussions (waiting on @faucomte97)
clusters_setup/deploy.py line 98 at r2 (raw file):
""" for rs in apps_api_instance.list_namespaced_replica_set("default").items: if rs.metadata.name == "aimmo-game-creator":
since we're no longer creating an aimmo-game-creator replica set in K8s, do we need to have this step of deleting it?
django_site/settings.py line 219 at r2 (raw file):
CSRF_COOKIE_SECURE = True AIMMO_DJANGO_BASE_URL = f"https://{os.getenv('GAE_SERVICE')}-dot-decent-digit-629.appspot.com"
where/why is this variable used?
There was a problem hiding this comment.
Reviewable status: 1 of 3 files reviewed, 2 unresolved discussions (waiting on @faucomte97 and @SKairinos)
clusters_setup/deploy.py line 98 at r2 (raw file):
Previously, SKairinos (Stefan Kairinos) wrote…
since we're no longer creating an aimmo-game-creator replica set in K8s, do we need to have this step of deleting it?
Done.
django_site/settings.py line 219 at r2 (raw file):
Previously, SKairinos (Stefan Kairinos) wrote…
where/why is this variable used?
In the aimmo PR:
There was a problem hiding this comment.
Reviewed 1 of 1 files at r2, 1 of 1 files at r3, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @faucomte97)
This change is