clip: geojson #2243
Merged
clip: geojson #2243
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbostock
reviewed
Nov 21, 2024
mbostock
reviewed
Nov 21, 2024
mbostock
reviewed
Nov 21, 2024
test/output/contourVaporClip.svg
Outdated
Co-authored-by: Mike Bostock <[email protected]>
mbostock
reviewed
Nov 21, 2024
tested in armadillo, by having two marks with these different clip values sharing the same clip-path
Fil
commented
Nov 22, 2024
mbostock
reviewed
Nov 22, 2024
mbostock
reviewed
Nov 22, 2024
mbostock
reviewed
Nov 22, 2024
Co-authored-by: Mike Bostock <[email protected]>
Co-authored-by: Mike Bostock <[email protected]>
Co-authored-by: Mike Bostock <[email protected]>
mbostock
reviewed
Nov 22, 2024
I wonder if we should still test for a type string or if doing the 10 tests is fast enough anyway
…avoid duplicating the clip-path
mbostock
reviewed
Nov 22, 2024
mbostock
reviewed
Nov 22, 2024
mbostock
reviewed
Nov 22, 2024
Co-authored-by: Mike Bostock <[email protected]>
…nto fil/clip-geo
mbostock
reviewed
Nov 24, 2024
Comment on lines
+239
to
+243
| // A path generator for marks that want to draw GeoJSON. | ||
| context.path = function () { | ||
| return geoPath(this.projection ?? xyProjection(scales)); | ||
| }; | ||
|
|
There was a problem hiding this comment.
I didn’t catch this in the review, but I think this should be assigned quite a bit earlier, especially before we pass the context to mark initializers.
This was referenced Nov 24, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note that one case escapes the memoization: the pointer transform creates a new context, and marks that use it get a second clip path.
closes #1109