Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace Svelte example with runes (v5.0.0+) and rm deprecated onmousemove #2242

Merged
merged 5 commits into from
Nov 24, 2024

Conversation

vincvdwal
Copy link
Contributor

No description provided.

@vincvdwal vincvdwal changed the title Replace with runes and rm deprecated onmousemove Replace Svelte examples with runes and rm deprecated onmousemove Nov 21, 2024
@vincvdwal vincvdwal changed the title Replace Svelte examples with runes and rm deprecated onmousemove Replace Svelte example with runes (v5.0.0+) and rm deprecated onmousemove Nov 21, 2024
@Fil
Copy link
Contributor

Fil commented Nov 22, 2024

Thanks! I think we also need to link to a different playground url.

(I pasted your changes and saved them to https://svelte.dev/playground/e65b5c87ae7e44239cef41ec3df28f52?version=5.2.7)

@vincvdwal
Copy link
Contributor Author

vincvdwal commented Nov 22, 2024

Np! I was wondering, maybe it needs 2 versions, since v5.0.0 with runes is kind of new? I don't know if a lot of people still use Svelte v4.x.x or prior. But I was kind of struggling getting it working with the new runes, that's why I opened this PR. I also thought about removing the Typescript stuff since it's actually optional in Svelte

@Fil
Copy link
Contributor

Fil commented Nov 22, 2024

We don't want to make this documentation about svelte versions. Being up-to-date is good if you're starting a new project. The typescript stuff is not overwhelming, and can be helpful, so I think we can keep it.

@Fil Fil enabled auto-merge (squash) November 24, 2024 16:47
@Fil Fil merged commit 283d8e1 into observablehq:main Nov 24, 2024
1 check passed
@vincvdwal vincvdwal deleted the feature/1-move-example-to-runes branch November 24, 2024 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants