Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix build error with missing Event #2185

Merged
merged 1 commit into from
Oct 2, 2024
Merged

fix build error with missing Event #2185

merged 1 commit into from
Oct 2, 2024

Conversation

Fil
Copy link
Contributor

@Fil Fil commented Oct 2, 2024

#2169 has introduced an error when building the documentation site; this routes around it. I haven't seen a difference in the public-facing result.

(I had mentioned the potential issue here but not seen where it would happen #2169 (comment))

TypeError: Cannot read properties of undefined (reading 'Event')
    at context.dispatchValue (file:///Users/fil/Source/plot/docs/.vitepress/.temp/index.C4JK4Fq9.js:6179:59)
    at render2 (file:///Users/fil/Source/plot/docs/.vitepress/.temp/index.C4JK4Fq9.js:3542:19)
    at Tip.<anonymous> (file:///Users/fil/Source/plot/docs/.vitepress/.temp/index.C4JK4Fq9.js:3583:14)
    at Tip.render (file:///Users/fil/Source/plot/docs/.vitepress/.temp/index.C4JK4Fq9.js:3329:15)
    at Module.plot (file:///Users/fil/Source/plot/docs/.vitepress/.temp/index.C4JK4Fq9.js:6254:25)
    at Proxy.render (file:///Users/fil/Source/plot/docs/.vitepress/.temp/PlotRender.Db8MMvNF.js:657:35)
    at renderComponentRoot (/Users/fil/Source/plot/node_modules/@vue/runtime-core/dist/runtime-core.cjs.prod.js:4892:16)
    at renderComponentSubTree (/Users/fil/Source/plot/node_modules/@vue/server-renderer/dist/server-renderer.cjs.prod.js:448:28)
    at renderComponentVNode (/Users/fil/Source/plot/node_modules/@vue/server-renderer/dist/server-renderer.cjs.prod.js:375:12)
    at ssrRenderComponent (/Users/fil/Source/plot/node_modules/@vue/server-renderer/dist/server-renderer.cjs.prod.js:84:10)

…his routes around it. I haven't seen a difference in the public-facing result.

(I had mentioned the potential issue here but not seen where it would happen
#2169 (comment))
@Fil Fil requested a review from mbostock October 2, 2024 15:44
@Fil Fil mentioned this pull request Oct 2, 2024
@Fil Fil merged commit 572fa9e into main Oct 2, 2024
1 check passed
@Fil Fil deleted the fil/event branch October 2, 2024 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants