Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

filterFacets is a private method of context #2180

Closed
wants to merge 1 commit into from
Closed

filterFacets is a private method of context #2180

wants to merge 1 commit into from

Conversation

Fil
Copy link
Contributor

@Fil Fil commented Sep 30, 2024 •
edited
Loading

I believe this is not usable outside of the axis mark, and we won't document it as being part of the API (#1811). So let's reinforce that with the customary _ prefix.

@Fil Fil enabled auto-merge (squash) September 30, 2024 08:46
mbostock
mbostock reviewed Sep 30, 2024
View reviewed changes
Copy link
Member

@mbostock mbostock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I put it in the same category as getMarkState. If we need it for the axis mark, it might be need for other marks in the future…

@Fil
Copy link
Contributor Author

Fil commented Sep 30, 2024

OK, I'll try harder to document it :)

@Fil Fil closed this Sep 30, 2024
auto-merge was automatically disabled September 30, 2024 15:13

Pull request was closed

@Fil Fil deleted the fil/private-context branch September 30, 2024 15:13
@Fil
Copy link
Contributor Author

Fil commented Oct 1, 2024

#2182

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mbostock mbostock mbostock left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Fil @mbostock