ignore / if the delimiter is something else #1850
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbostock
reviewed
Sep 7, 2023
|
I added more test cases. Unfortunately I found there’s even a bug in the slash case! |
|
Update: the test was slightly wrong, we need six (!) backslashes to have |
mbostock
force-pushed
the
fil/tree-delimiter
branch
from
850dd7d to
0385c01
Compare
mbostock
approved these changes
Sep 12, 2023
|
In the documentation, do we want to specify “a character" in Line 63 in e22c41e |
(note: I don't think this is the correct fix! But at least it gives a unit test) closes #1849
mbostock
force-pushed
the
fil/tree-delimiter
branch
from
298362b to
5df247a
Compare
Fil
added a commit
that referenced
this pull request
Sep 13, 2023
* ignore / if the delimiter is something else (note: I don't think this is the correct fix! But at least it gives a unit test) closes #1849 * avoid string.replaceAll * add delimiter test * \/ needs three (six) backslashes! * pass tests, but still not complete * proper escape/unescape * refactor logic * lift delimiter code * tweak error message * refactor logic slightly --------- Co-authored-by: Mike Bostock <[email protected]>
chaichontat
pushed a commit
to chaichontat/plot
that referenced
this pull request
Jan 14, 2024
* ignore / if the delimiter is something else (note: I don't think this is the correct fix! But at least it gives a unit test) closes observablehq#1849 * avoid string.replaceAll * add delimiter test * \/ needs three (six) backslashes! * pass tests, but still not complete * proper escape/unescape * refactor logic * lift delimiter code * tweak error message * refactor logic slightly --------- Co-authored-by: Mike Bostock <[email protected]>
This was referenced Jul 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't think this is the correct fix! But at least it gives a unit test.
closes #1849