fix tickFormat type inference for empty domain (#2232)

observablehq · Nov 15, 2024 · ff7d83c · ff7d83c
1 parent 653af62
commit ff7d83c
Show file tree

Hide file tree

Showing 5 changed files with 46 additions and 2 deletions.
diff --git a/src/marks/axis.js b/src/marks/axis.js
@@ -672,10 +672,10 @@ export function inferTickFormat(scale, data, ticks, tickFormat, anchor) {
     ? inferTimeFormat(scale.type, data, anchor) ?? formatDefault
     : scale.tickFormat
     ? scale.tickFormat(typeof ticks === "number" ? ticks : null, tickFormat)
+    : typeof tickFormat === "string" && scale.domain().length > 0
+    ? (isTemporal(scale.domain()) ? utcFormat : format)(tickFormat)
     : tickFormat === undefined
     ? formatDefault
-    : typeof tickFormat === "string"
-    ? (isTemporal(scale.domain()) ? utcFormat : format)(tickFormat)
     : constant(tickFormat);
 }
 

diff --git a/test/output/tickFormatEmptyDomain.svg b/test/output/tickFormatEmptyDomain.svg
diff --git a/test/output/tickFormatEmptyFacetDomain.svg b/test/output/tickFormatEmptyFacetDomain.svg
diff --git a/test/plots/index.ts b/test/plots/index.ts
@@ -309,6 +309,7 @@ export * from "./style-overrides.js";
 export * from "./symbol-set.js";
 export * from "./text-overflow.js";
 export * from "./this-is-just-to-say.js";
+export * from "./tick-format.js";
 export * from "./time-axis.js";
 export * from "./tip-format.js";
 export * from "./tip.js";

diff --git a/test/plots/tick-format.ts b/test/plots/tick-format.ts
@@ -0,0 +1,9 @@
+import * as Plot from "@observablehq/plot";
+
+export async function tickFormatEmptyDomain() {
+  return Plot.plot({y: {tickFormat: "%W"}, marks: [Plot.barX([]), Plot.frame()]});
+}
+
+export async function tickFormatEmptyFacetDomain() {
+  return Plot.plot({fy: {tickFormat: "%W"}, marks: [Plot.barX([]), Plot.frame()]});
+}