fix waffle stroke (when constant)

observablehq · Oct 19, 2024 · d3f851e · d3f851e
1 parent c1aab3b
commit d3f851e
Show file tree

Hide file tree

Showing 9 changed files with 815 additions and 109 deletions.
diff --git a/src/marks/waffle.js b/src/marks/waffle.js
@@ -34,8 +34,8 @@ export class WaffleY extends BarY {
 }
 
 function waffleRender(y) {
-    const {unit, gap, rx, ry, round} = this;
   return function (index, scales, {href, ...values}, dimensions, context) {
+    const {unit, gap, rx, ry, round} = this;
     const {document} = context;
     const Y1 = values.channels[`${y}1`].value;
     const Y2 = values.channels[`${y}2`].value;
@@ -103,7 +103,7 @@ function waffleRender(y) {
                 .join("L")}Z`
           )
           .attr("fill", (i) => `url(#${patternId}-${i})`)
-          .attr("stroke", this.stroke == null ? null : (i) => `url(#${patternId}-${i})`)
+          .attr("stroke", this.stroke == null ? null : "none")
           .call(applyChannelStyles, this, {href})
       )
       .node();

diff --git a/test/output/waffleHref.svg b/test/output/waffleHref.svg
diff --git a/test/output/waffleStroke.svg b/test/output/waffleStroke.svg
diff --git a/test/output/waffleStrokeMixed.svg b/test/output/waffleStrokeMixed.svg