no default identity fill if stroke channel

observablehq · May 1, 2021 · ca998dd · ca998dd
1 parent a720c1c
commit ca998dd
Show file tree

Hide file tree

Showing 3 changed files with 34 additions and 32 deletions.
diff --git a/src/marks/cell.js b/src/marks/cell.js
@@ -1,4 +1,4 @@
-import {identity, indexOf, maybeTuple} from "../mark.js";
+import {identity, indexOf, maybeColor, maybeTuple} from "../mark.js";
 import {AbstractBar} from "./bar.js";
 
 export class Cell extends AbstractBar {
@@ -25,10 +25,12 @@ export function cell(data, {x, y, ...options} = {}) {
   return new Cell(data, {...options, x, y});
 }
 
-export function cellX(data, {x = indexOf, fill = identity, ...options} = {}) {
-  return new Cell(data, {...options, x, fill});
+export function cellX(data, {x = indexOf, fill, stroke, ...options} = {}) {
+  if (fill === undefined && maybeColor(stroke)[0] === undefined) fill = identity;
+  return new Cell(data, {...options, x, fill, stroke});
 }
 
-export function cellY(data, {y = indexOf, fill = identity, ...options} = {}) {
-  return new Cell(data, {...options, y, fill});
+export function cellY(data, {y = indexOf, fill, stroke, ...options} = {}) {
+  if (fill === undefined && maybeColor(stroke)[0] === undefined) fill = identity;
+  return new Cell(data, {...options, y, fill, stroke});
 }
diff --git a/test/output/highCardinalityOrdinal.svg b/test/output/highCardinalityOrdinal.svg
diff --git a/test/plots/high-cardinality-ordinal.js b/test/plots/high-cardinality-ordinal.js
@@ -6,7 +6,7 @@ export default async function() {
       type: "ordinal"
     },
     marks: [
-      Plot.cellX("ABCDEFGHIJKLMNOPQRSTUVWXYZ", {x: d => d})
+      Plot.cellX("ABCDEFGHIJKLMNOPQRSTUVWXYZ")
     ]
   });
 }