Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deploy option to enable continuous deployment #1745

Open
wants to merge 50 commits into
base: main
Choose a base branch
from
Open

Deploy option to enable continuous deployment #1745

wants to merge 50 commits into from

Commits on Oct 4, 2024

  1. checkpoint - kicking off cloud build from cli sorta working

    @tophtucker
    tophtucker committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    adaa867 View commit details
    Browse the repository at this point in the history

Commits on Oct 8, 2024

  1. correct ellipsis

    @tophtucker
    tophtucker committed Oct 8, 2024
    Configuration menu
    Copy the full SHA
    fa5e762 View commit details
    Browse the repository at this point in the history

Commits on Oct 11, 2024

  1. continuousDeployment flag persisted in deploy.json

    @tophtucker
    tophtucker committed Oct 11, 2024
    Configuration menu
    Copy the full SHA
    6e614ca View commit details
    Browse the repository at this point in the history

  2. poll for repo access

    @tophtucker
    tophtucker committed Oct 11, 2024
    Configuration menu
    Copy the full SHA
    a7efd4c View commit details
    Browse the repository at this point in the history

  3. cleanup. remove "Do you wanna link GitHub" prompt, since you have to

    @tophtucker
    tophtucker committed Oct 11, 2024
    Configuration menu
    Copy the full SHA
    1077838 View commit details
    Browse the repository at this point in the history

Commits on Oct 15, 2024

  1. various post-demo cleanup; maybeLinkGitHub even if we’re not enabling… 

    … continuousDeployment for the first time
    @tophtucker
    tophtucker committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    44b1e5f View commit details
    Browse the repository at this point in the history

  2. better handling of the case where github is not connected at all; set… 

    … primary branch in our db to current branch; add some periods to some messages where it seems appropriate for consistency
    @tophtucker
    tophtucker committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    b6c2a3f View commit details
    Browse the repository at this point in the history

  3. throw Error → throw new Error 

    Co-authored-by: Mike Bostock <[email protected]>
    @tophtucker @mbostock
    tophtucker and mbostock authored Oct 15, 2024
    Configuration menu
    Copy the full SHA
    bb790ef View commit details
    Browse the repository at this point in the history

  4. Merge branch 'main' into toph/onramp

    @tophtucker
    tophtucker committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    93203ca View commit details
    Browse the repository at this point in the history

  5. fix existing tests

    @tophtucker
    tophtucker committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    8128173 View commit details
    Browse the repository at this point in the history

Commits on Oct 22, 2024

  1. start on docs

    @tophtucker
    tophtucker committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    56e4d14 View commit details
    Browse the repository at this point in the history

Commits on Oct 25, 2024

  1. Merge branch 'main' into toph/onramp

    @tophtucker
    tophtucker committed Oct 25, 2024
    Configuration menu
    Copy the full SHA
    6f7c852 View commit details
    Browse the repository at this point in the history

  2. use new singular endpoint to see if repo is authed

    @tophtucker
    tophtucker committed Oct 25, 2024
    Configuration menu
    Copy the full SHA
    9e234a2 View commit details
    Browse the repository at this point in the history

Commits on Oct 26, 2024

  1. clean up logic, more dry

    @tophtucker
    tophtucker committed Oct 26, 2024
    Configuration menu
    Copy the full SHA
    c9effe0 View commit details
    Browse the repository at this point in the history

Commits on Oct 29, 2024

  1. rm getProjectEnvironment calls

    @tophtucker
    tophtucker committed Oct 29, 2024
    Configuration menu
    Copy the full SHA
    8c75f52 View commit details
    Browse the repository at this point in the history

Commits on Oct 30, 2024

  1. link to internal interstitial screen instead of directly to github

    @tophtucker
    tophtucker committed Oct 30, 2024
    Configuration menu
    Copy the full SHA
    75cbf50 View commit details
    Browse the repository at this point in the history

  2. slightly more human-readable error message

    @tophtucker
    tophtucker committed Oct 30, 2024
    Configuration menu
    Copy the full SHA
    e80786b View commit details
    Browse the repository at this point in the history

  3. dont change continuousDeployment setting as a side effect of github l… 

    …ink failing
    @tophtucker
    tophtucker committed Oct 30, 2024
    Configuration menu
    Copy the full SHA
    ea676b1 View commit details
    Browse the repository at this point in the history

Commits on Oct 31, 2024

  1. flatten structure of maybeLinkGitHub with early returns

    @tophtucker
    tophtucker committed Oct 31, 2024
    Configuration menu
    Copy the full SHA
    06b52f7 View commit details
    Browse the repository at this point in the history

  2. rename maybeLinkGitHub: boolean to validateGitHubLink: void, more err… 

    …or throwing, check local repo against configured remote repo, just repo and branch, not yet refs
    @tophtucker
    tophtucker committed Oct 31, 2024
    Configuration menu
    Copy the full SHA
    a7ba250 View commit details
    Browse the repository at this point in the history

Commits on Nov 1, 2024

  1. support SSH github remotes

    @tophtucker
    tophtucker committed Nov 1, 2024
    Configuration menu
    Copy the full SHA
    5830afc View commit details
    Browse the repository at this point in the history

  2. move validateGitHubLink call to a better higher clearer more consolid… 

    …ated spot
    @tophtucker
    tophtucker committed Nov 1, 2024
    Configuration menu
    Copy the full SHA
    048fd88 View commit details
    Browse the repository at this point in the history

  3. tweak cd prompt to clarify that you need a github repo

    @tophtucker
    tophtucker committed Nov 1, 2024
    Configuration menu
    Copy the full SHA
    7c719ae View commit details
    Browse the repository at this point in the history

  4. Merge branch 'main' into toph/onramp

    @tophtucker
    tophtucker committed Nov 1, 2024
    Configuration menu
    Copy the full SHA
    a6ac45e View commit details
    Browse the repository at this point in the history

  5. minimize diff

    @tophtucker
    tophtucker committed Nov 1, 2024
    Configuration menu
    Copy the full SHA
    8407f88 View commit details
    Browse the repository at this point in the history

  6. minimize diff, again

    @tophtucker
    tophtucker committed Nov 1, 2024
    Configuration menu
    Copy the full SHA
    476ebec View commit details
    Browse the repository at this point in the history

Commits on Nov 2, 2024

  1. first tests of validateGitHubLink

    @tophtucker
    tophtucker committed Nov 2, 2024
    Configuration menu
    Copy the full SHA
    bc60124 View commit details
    Browse the repository at this point in the history

  2. whoohoo end-to-end test of kicking off cloud build

    @tophtucker
    tophtucker committed Nov 2, 2024
    Configuration menu
    Copy the full SHA
    14ce19b View commit details
    Browse the repository at this point in the history

  3. ALL TESTS PASSING incl coverage threshold, thanks to testing cloud bu… 

    …ild of preconfigured project
    @tophtucker
    tophtucker committed Nov 2, 2024
    Configuration menu
    Copy the full SHA
    27128bb View commit details
    Browse the repository at this point in the history

  4. Merge branch 'main' into toph/onramp

    @tophtucker
    tophtucker committed Nov 2, 2024
    Configuration menu
    Copy the full SHA
    3a5de29 View commit details
    Browse the repository at this point in the history

  5. move mockIsolatedDirectory to own file

    @tophtucker
    tophtucker committed Nov 2, 2024
    Configuration menu
    Copy the full SHA
    82f7b0d View commit details
    Browse the repository at this point in the history

  6. Merge branch 'main' into toph/onramp

    @tophtucker
    tophtucker committed Nov 2, 2024
    Configuration menu
    Copy the full SHA
    105f0ed View commit details
    Browse the repository at this point in the history

  7. testing if git is installed on ubuntu

    @tophtucker
    tophtucker committed Nov 2, 2024
    Configuration menu
    Copy the full SHA
    e511cc7 View commit details
    Browse the repository at this point in the history

  8. testing deterministic default branch name

    @tophtucker
    tophtucker committed Nov 2, 2024
    Configuration menu
    Copy the full SHA
    bb9c311 View commit details
    Browse the repository at this point in the history

  9. more debugging...

    @tophtucker
    tophtucker committed Nov 2, 2024
    Configuration menu
    Copy the full SHA
    ff60b80 View commit details
    Browse the repository at this point in the history

  10. setting name and email config for git, seeing if that helps

    @tophtucker
    tophtucker committed Nov 2, 2024
    Configuration menu
    Copy the full SHA
    f1cd74d View commit details
    Browse the repository at this point in the history

  11. fix command separator from ; to && for windows; prettier for ubuntu

    @tophtucker
    tophtucker committed Nov 2, 2024
    Configuration menu
    Copy the full SHA
    e188a39 View commit details
    Browse the repository at this point in the history

  12. use fs instead of touch for cross-platform (windows) compatibility; f… 

    …ix prettttier thing i missed
    @tophtucker
    tophtucker committed Nov 2, 2024
    Configuration menu
    Copy the full SHA
    fae07e1 View commit details
    Browse the repository at this point in the history

  13. force: true on rm dir for windows complaining ENOTEMPTY

    @tophtucker
    tophtucker committed Nov 2, 2024
    Configuration menu
    Copy the full SHA
    41f9682 View commit details
    Browse the repository at this point in the history

  14. adopting rimraf in lieu of node fs rm for what i hope is better windo… 

    …ws compatibility
    Observable User committed Nov 2, 2024
    Configuration menu
    Copy the full SHA
    dd50d70 View commit details
    Browse the repository at this point in the history

  15. oops i wasnt actually closing the file i made. good call, windows. ro… 

    …lling back other forcing things to see if i still need them
    Observable User committed Nov 2, 2024
    Configuration menu
    Copy the full SHA
    3f0bbb8 View commit details
    Browse the repository at this point in the history

  16. ah i had another case of touch

    Observable User committed Nov 2, 2024
    Configuration menu
    Copy the full SHA
    fede926 View commit details
    Browse the repository at this point in the history

  17. new test for when repo doesnt match

    Observable User committed Nov 2, 2024
    Configuration menu
    Copy the full SHA
    172bf50 View commit details
    Browse the repository at this point in the history

  18. add test for polling for repo auth; deploy.ts test coverage is now ba… 

    …ck up to status quo ante; fix polling for auth to respect deployOptions.deployPollInterval, though one could argue its now too narrowly named
    Observable User committed Nov 2, 2024
    Configuration menu
    Copy the full SHA
    87f707d View commit details
    Browse the repository at this point in the history

  19. WHEW i think everything should be passing now, removing debug console… 

    … log junk
    Observable User committed Nov 2, 2024
    Configuration menu
    Copy the full SHA
    159d708 View commit details
    Browse the repository at this point in the history

  20. lmao last few commits are attributed to my test user bc the exec git … 

    …stuff isnt isolated so running the tests changed my email and name. happy to have you as a collaborator, Observable User. removed --global flag... duh...
    @tophtucker
    tophtucker authored and --global committed Nov 2, 2024
    Configuration menu
    Copy the full SHA
    1a5c9f9 View commit details
    Browse the repository at this point in the history

  21. now that were not setting the git config options globally we have to … 

    …init FIRST, duh duh duh
    --global committed Nov 2, 2024
    Configuration menu
    Copy the full SHA
    4a8e4e7 View commit details
    Browse the repository at this point in the history

  22. set initial branch when initializing repo instead of setting the defa… 

    …ult branch after repo is already made, which of course does nothing for the current repo
    --global committed Nov 2, 2024
    Configuration menu
    Copy the full SHA
    a23c35c View commit details
    Browse the repository at this point in the history

Commits on Nov 8, 2024

  1. Merge branch 'main' into toph/onramp

    @Fil
    Fil authored Nov 8, 2024
    Configuration menu
    Copy the full SHA
    36e2153 View commit details
    Browse the repository at this point in the history

Commits on Nov 12, 2024

  1. Fil/onramp review (#1805) 

    * documentation

* reformat and type

* simpler

* clarify the logic in validateGitHubLink
fixes an uncaught Error ('Setting source repository for continuous deployment failed' was never reached)
    @Fil
    Fil authored Nov 12, 2024
    Configuration menu
    Copy the full SHA
    3e5e669 View commit details
    Browse the repository at this point in the history