Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Windows Build CMP0135 Policy Deprecation #579

Closed
wants to merge 4 commits into from

Conversation

TK5gL2dS5uwQc
Copy link

@TK5gL2dS5uwQc TK5gL2dS5uwQc commented Nov 9, 2023

@TK5gL2dS5uwQc TK5gL2dS5uwQc reopened this Nov 9, 2023
@TK5gL2dS5uwQc TK5gL2dS5uwQc marked this pull request as ready for review November 9, 2023 21:01
@TK5gL2dS5uwQc
Copy link
Author

First time contributing to a public GitHub repo. Please let me know if I need to do something additional.

@greenrobot-team greenrobot-team self-requested a review November 13, 2023 06:58
@greenrobot-team
Copy link
Member

Thank you! I'll have a look when I have time.

For me: from a first look the used option is not added until 3.24, but the minimum supported CMake is lower. Check how that works on older versions. Also the docs note that enabling specific policies is discouraged.

@TK5gL2dS5uwQc
Copy link
Author

TK5gL2dS5uwQc commented Nov 13, 2023

Ok, great. I'll take a look at those docs and figure out why these checks* are failing later, potentially today.

@greenrobot-team
Copy link
Member

greenrobot-team commented Nov 14, 2023

@ikelly963 Don't worry about the failling checks. pana fails because I need to still adjust the threshold and coverage just has no permission to upload the report because this is a branch outside of this repo.

@greenrobot-team
Copy link
Member

The Flutter folks have a better fix. But I'm not sure it's still needed. See #522 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants