Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Web support vol.1 #189

Merged
merged 5 commits into from
Mar 8, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/lint.yml
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ jobs:
- name: Check scores
shell: bash
run: |
if [[ "90" -gt "${{ steps.analysis.outputs.total }}" ]]; then
echo "Score is less then 90, please check the analysis report and resolve the issues"
if [[ "100" -gt "${{ steps.analysis.outputs.total }}" ]]; then
echo "Score is less then 100, please check the analysis report and resolve the issues"
exit 1
fi
1 change: 0 additions & 1 deletion generator/integration-tests/basics/1.dart
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@ import 'lib/objectbox.g.dart';
import 'package:test/test.dart';
import '../test_env.dart';
import '../common.dart';
import 'package:objectbox/src/bindings/bindings.dart';

void main() {
TestEnv<A> env;
Expand Down
1 change: 0 additions & 1 deletion generator/integration-tests/indexes/1.dart
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@ import 'lib/objectbox.g.dart';
import 'package:test/test.dart';
import '../test_env.dart';
import '../common.dart';
import 'package:objectbox/src/bindings/bindings.dart';

void main() {
TestEnv<A> env;
Expand Down
2 changes: 1 addition & 1 deletion generator/lib/src/code_chunks.dart
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import 'dart:convert';

import 'package:objectbox/src/modelinfo/index.dart';
import 'package:objectbox/src/bindings/bindings.dart';
import 'package:source_gen/source_gen.dart' show InvalidGenerationSourceError;

class CodeChunks {
Expand Down
2 changes: 0 additions & 2 deletions generator/lib/src/entity_resolver.dart
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,6 @@ import 'package:analyzer/dart/element/type.dart';
import 'package:build/build.dart';
import 'package:objectbox/objectbox.dart';
import 'package:objectbox/internal.dart';
import 'package:objectbox/src/bindings/bindings.dart';
import 'package:objectbox/src/bindings/helpers.dart';
import 'package:objectbox/src/modelinfo/index.dart';
import 'package:source_gen/source_gen.dart';

Expand Down
3 changes: 2 additions & 1 deletion objectbox/analysis_options.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,8 @@ analyzer:
- example/**
- generator/**
- benchmark/**
- lib/src/bindings/objectbox-c.dart
- lib/src/modelinfo/enums.dart
- lib/src/native/bindings/objectbox-c.dart
- lib/flatbuffers/** # Not really our code
- test/objectbox.g.dart # TODO remove exception after #168 is implemented
strong-mode:
Expand Down
6 changes: 3 additions & 3 deletions objectbox/lib/integration_test.dart
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
library integration_test;

import './src/bindings/bindings.dart';
import './src/bindings/helpers.dart';
import './src/native/bindings/bindings.dart' as native;
import './src/native/bindings/helpers.dart' as native;
import 'internal.dart';

// ignore_for_file: public_member_api_docs
Expand Down Expand Up @@ -31,6 +31,6 @@ class IntegrationTest {
modelInfo.validate();

final model = Model(modelInfo);
checkObx(C.model_free(model.ptr));
native.checkObx(native.C.model_free(model.ptr));
}
}
2 changes: 1 addition & 1 deletion objectbox/lib/internal.dart
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ library objectbox_internal;

export 'src/model.dart';
export 'src/modelinfo/index.dart';
export 'src/query/query.dart'
export 'src/query.dart'
// don't export the same things as objectbox.dart to avoid docs conflicts
hide
Query,
Expand Down
2 changes: 1 addition & 1 deletion objectbox/lib/objectbox.dart
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ export 'src/annotations.dart';
export 'src/box.dart' show Box;
export 'src/common.dart';
export 'src/observable.dart';
export 'src/query/query.dart'
export 'src/query.dart'
show
Query,
QueryBuilder,
Expand Down
Loading