Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add editor's note about relation b/t OBI & CHEBI: solvent/solvent role #1778

Closed
wants to merge 1 commit into from

Conversation

sebastianduesing
Copy link
Contributor

Closes #1771. Adds an editor's note to OBI:"solvent role" specifying the difference between it and CHEBI:"solvent," using language proposed by @bpeters42.

@bpeters42 bpeters42 self-requested a review April 15, 2024 16:43
Copy link
Contributor

@bpeters42 bpeters42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reviewed in OBI call 4/15

@turbomam
Copy link
Contributor

An editor note like this is a good way of adding clarity, but I beleive that, as of April 2024, roles and material entities are disjoint in ChEBI, and this particular editor note is actually misleading.

2024-04-22 OBI call
It is concerning that roles and material entities in ChEBI may have been less clear in the past, and if a change was made, we don't know about it in this OBI call.

Copy link
Contributor

@cmungall cmungall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with @turbomam. In fact these branches have always been disjoint.

@bpeters42
Copy link
Contributor

I cannot reconstruct what I had looked at before, and @turbomam and @cmungall are completely right. We should not add this comment, and go back to the issue.

@bpeters42 bpeters42 self-requested a review April 23, 2024 16:51
@bpeters42 bpeters42 closed this Apr 29, 2024
@bpeters42
Copy link
Contributor

Closing this PR to revisit the discussion on the issue itself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Harmonize OBI:solvent role and CHEBI:solvent
4 participants