net.c: memory leak in handle_request if error input #536
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build fails - needs #532 |
obgm
reviewed
Aug 12, 2020
src/net.c
Outdated
| @@ -2366,6 +2366,10 @@ handle_request(coap_context_t *context, coap_session_t *session, coap_pdu_t *pdu | |||
| response = NULL; | |||
| } else { | |||
| coap_log(LOG_WARNING, "cannot generate response\r\n"); | |||
| if (response) { | |||
There was a problem hiding this comment.
The delete functions in libcoap are all designed to be callable with a NULL argument, analogous to free(). Therefore, we can do without the extra check here.
There was a problem hiding this comment.
Code updated and pushed.
coap_add_token() can error for multiple reasons when building the response PDU - but then the response PDU is not deleted on error if it exists. The PDU is now deleted on coap_add_token() error.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
coap_add_token() can error for multiple reasons when building the response
PDU - but then the response PDU is not deleted on error if it exists.
The PDU is now deleted on coap_add_token() error.
Fixes #535