Merge pull request #29 from greg-hellings/add_flexible_hostname_ip

Add optional IP address for hostnames

roles/hostname/defaults/main.yml

@@ -1,6 +1,7 @@
 hostname: "{{ ansible_fqdn }}"
 hostname_aliases: []
 hostname_inject_hosts_files: true
+hostname_inject_hosts_ip_address: "127.0.0.1"
 
 # For host file inject task only
 hostname_become: true

roles/hostname/molecule/default/molecule.yml

@@ -2,6 +2,3 @@ driver:
   name: openstack
 platforms:
   - name: hostname_default
-provisioner:
-  playbooks:
-    converge: playbook.yml

roles/hostname/molecule/set_ip/molecule.yml

@@ -0,0 +1,9 @@
+driver:
+  name: openstack
+platforms:
+  - name: hostname_default
+provisioner:
+  inventory:
+    group_vars:
+      all:
+        hostname_inject_hosts_ip_address: "1.2.3.4"

roles/hostname/molecule/set_ip/tests/test_hostname.py

@@ -0,0 +1,20 @@
+def test_hostname_set(host):
+    assert host.run("hostname -f").stdout.strip() == "dev.example.com"
+
+
+def test_hostname_resolves(host):
+    cmd = _call(host, 'dev.example.com')
+    assert cmd == '1.2.3.4'
+
+
+def test_hostname_aliases_resolve(host):
+    cmd = _call(host, 'dev')
+    assert cmd == '1.2.3.4'
+
+
+def _call(host, name):
+    cmd = host.run("ping -c 1 dev.example.com")
+    lines = cmd.stdout.split("\n")
+    line = lines[0]
+    line = line[line.find('(') + 1:line.find(')')]
+    return line

roles/hostname/tasks/main.yml

@@ -6,7 +6,7 @@
 - name: inject hostname to hosts file
   blockinfile:
     path: /etc/hosts
-    block: "127.0.0.1 {{ hostname }} {{ hostname_aliases | join(' ') }}"
+    block: "{{ hostname_inject_hosts_ip_address }} {{ hostname }} {{ hostname_aliases | join(' ') }}"
     state: present
   become: "{{ hostname_become }}"
   become_user: "{{ hostname_become_user }}"