Reload EFI info, boot order has changed as Leapp upgrade efi entry was removed

[yuravk]

Removing Leapp upgrade efi entry changes boot order. Because of that, BootNext fails:

Dec 02 13:47:00 localhost upgrade[654]: leapp.libraries.stdlib.CalledProcessError: Command ['/usr/sbin/efibootmgr', '--bootnext', '0004'] failed with exit code 12.
Dec 02 13:47:01 localhost upgrade[654]: =========================================================================================================
Dec 02 13:47:01 localhost upgrade[654]: Actor remove_upgrade_efi_entry unexpectedly terminated with exit code: 1 - Please check the above details

It is required to reload EFI info prior running efibootmgr --bootnext

[github-actions]

Thank you for contributing to the Leapp project!

Please note that every PR needs to comply with the Leapp Guidelines and must pass all tests in order to be mergeable.
If you want to request a review or rebuild a package in copr, you can use following commands as a comment:

• review please @oamg/developers to notify leapp developers of the review request
• /packit copr-build to submit a public copr build using packit

Packit will automatically schedule regression tests for this PR's build and latest upstream leapp build.
However, here are additional useful commands for packit:

• /packit test to re-run manually the default tests
• /packit retest-failed to re-run failed tests manually
• /packit test oamg/leapp#42 to run tests with leapp builds for the leapp PR#42 (default is latest upstream - main - build)

Note that first time contributors cannot run tests automatically - they need to be started by a reviewer.

It is possible to schedule specific on-demand tests as well. Currently 2 test sets are supported, beaker-minimal and kernel-rt, both can be used to be run on all upgrade paths or just a couple of specific ones.
To launch on-demand tests with packit:

• /packit test --labels kernel-rt to schedule kernel-rt tests set for all upgrade paths
• /packit test --labels beaker-minimal-8.10to9.4,kernel-rt-8.10to9.4 to schedule kernel-rt and beaker-minimal test sets for 8.10->9.4 upgrade path

See other labels for particular jobs defined in the .packit.yaml file.

Please open ticket in case you experience technical problem with the CI. (RH internal only)

Note: In case there are problems with tests not being triggered automatically on new PR/commit or pending for a long time, please contact leapp-infra.

[dkubek]

Hi @yuravk ! Thanks for the contribution!

It looks like you fix the issue by consuming ArmWorkaroundEFIBootloaderInfo again which should give you again the same bootloader_info as has been initialized previously, and therefore it should have no effect (or behave in exactly the same way), so I find it very curious if it fixes the issue.

I am much more interested in the issue itself, if such an error occurs there is probably an error somewhere else. Could you please provide me with a reproducer?

Thanks!

[yuravk]

Hi @dkubek ,

Thanks for your comments.
Unfortunately I'm not able to reproduce the issue anymore. Tried twice. The actor works.

I'm closing the PR as it seems to be not relevant.