Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IPU 7 -> 8: scangrubdevpartitionlayout: Skip warning msgs #1306

Merged
merged 1 commit into from
Nov 12, 2024

Conversation

pirat89
Copy link
Member

@pirat89 pirat89 commented Nov 12, 2024

The fdisk output can contain warning msgs when a partition is not alligned on physical sector boundary, like:
Partition 4 does not start on physical sector boundary.
We know that in case of MBR the line we expect to parse always starts with canonical path. So let's skip all lines which does not start with '/'.

jira: https://issues.redhat.com/browse/RHEL-50947

@pirat89 pirat89 added the bug Something isn't working label Nov 12, 2024
@pirat89 pirat89 added this to the 8.10/9.6 milestone Nov 12, 2024
Copy link

Thank you for contributing to the Leapp project!

Please note that every PR needs to comply with the Leapp Guidelines and must pass all tests in order to be mergeable.
If you want to request a review or rebuild a package in copr, you can use following commands as a comment:

  • review please @oamg/developers to notify leapp developers of the review request
  • /packit copr-build to submit a public copr build using packit

Packit will automatically schedule regression tests for this PR's build and latest upstream leapp build.
However, here are additional useful commands for packit:

  • /packit test to re-run manually the default tests
  • /packit retest-failed to re-run failed tests manually
  • /packit test oamg/leapp#42 to run tests with leapp builds for the leapp PR#42 (default is latest upstream - main - build)

Note that first time contributors cannot run tests automatically - they need to be started by a reviewer.

It is possible to schedule specific on-demand tests as well. Currently 2 test sets are supported, beaker-minimal and kernel-rt, both can be used to be run on all upgrade paths or just a couple of specific ones.
To launch on-demand tests with packit:

  • /packit test --labels kernel-rt to schedule kernel-rt tests set for all upgrade paths
  • /packit test --labels beaker-minimal-8.10to9.4,kernel-rt-8.10to9.4 to schedule kernel-rt and beaker-minimal test sets for 8.10->9.4 upgrade path

See other labels for particular jobs defined in the .packit.yaml file.

Please open ticket in case you experience technical problem with the CI. (RH internal only)

Note: In case there are problems with tests not being triggered automatically on new PR/commit or pending for a long time, please contact leapp-infra.

The fdisk output can contain warning msgs when a partition is not
aligned on physical sector boundary, like:
    Partition 4 does not start on physical sector boundary.
We know that in case of MBR the line we expect to parse always
starts with canonical path. So let's skip all lines which does
not start with '/'.

jira: https://issues.redhat.com/browse/RHEL-50947
@pirat89 pirat89 force-pushed the fix-first-partition-scan branch from 5d2c2c1 to 9db652d Compare November 12, 2024 08:19
@pirat89
Copy link
Member Author

pirat89 commented Nov 12, 2024

@andywaltlova thanks for the prompt review! ❤️

@pirat89 pirat89 merged commit 0bf07d1 into oamg:main Nov 12, 2024
18 of 26 checks passed
@pirat89 pirat89 deleted the fix-first-partition-scan branch November 12, 2024 08:36
@pirat89 pirat89 added the changelog-checked The merger/reviewer checked the changelog draft document and updated it when relevant label Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working changelog-checked The merger/reviewer checked the changelog draft document and updated it when relevant
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants