Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rhui setups support alibaba cloud for arm64 #1277

Merged
merged 1 commit into from
Aug 19, 2024
Merged

Conversation

jinkkkang
Copy link
Contributor

@jinkkkang jinkkkang commented Aug 12, 2024

rhui(alibaba): add ARM RHEL8 and RHEL9 setup entries

Since leapp's RHUI mechanism filters setups based on the architecture of the source system,
it was not possible to upgrade of ARM-based RHEL systems on Alibaba cloud as there
were no ARM entries in RHUI_SETUPS. This patch adds these entries, making it possible
for 8>9 upgrades of ARM systems on Alibaba cloud.


related jira: https://issues.redhat.com/browse/RHEL-53181

Copy link

Thank you for contributing to the Leapp project!

Please note that every PR needs to comply with the Leapp Guidelines and must pass all tests in order to be mergeable.
If you want to request a review or rebuild a package in copr, you can use following commands as a comment:

  • review please @oamg/developers to notify leapp developers of the review request
  • /packit copr-build to submit a public copr build using packit

Packit will automatically schedule regression tests for this PR's build and latest upstream leapp build.
However, here are additional useful commands for packit:

  • /packit test to re-run manually the default tests
  • /packit retest-failed to re-run failed tests manually
  • /packit test oamg/leapp#42 to run tests with leapp builds for the leapp PR#42 (default is latest upstream - master - build)

Note that first time contributors cannot run tests automatically - they need to be started by a reviewer.

It is possible to schedule specific on-demand tests as well. Currently 2 test sets are supported, beaker-minimal and kernel-rt, both can be used to be run on all upgrade paths or just a couple of specific ones.
To launch on-demand tests with packit:

  • /packit test --labels kernel-rt to schedule kernel-rt tests set for all upgrade paths
  • /packit test --labels beaker-minimal-8.10to9.4,kernel-rt-8.10to9.4 to schedule kernel-rt and beaker-minimal test sets for 8.10->9.4 upgrade path

See other labels for particular jobs defined in the .packit.yaml file.

Please open ticket in case you experience technical problem with the CI. (RH internal only)

Note: In case there are problems with tests not being triggered automatically on new PR/commit or pending for a long time, please contact leapp-infra.

@pirat89
Copy link
Member

pirat89 commented Aug 12, 2024

/packit copr-build

@pirat89 pirat89 added this to the 8.10/9.5 milestone Aug 12, 2024
@pirat89 pirat89 requested a review from MichalHe August 12, 2024 10:13
Copy link
Member

@MichalHe MichalHe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests are passing and code-wise the patch looks fine.

@MichalHe
Copy link
Member

@jinkkkang Could you maybe provide a better commit message, please? Something like

rhui(alibaba): add ARM RHEL8 and RHEL9 setup entries

Since leapp's RHUI mechanism filters setups based on the architecture of the source system,
it was not possible to upgrade of ARM-based RHEL systems on Alibaba cloud as there
were no ARM entries in RHUI_SETUPS. This patch adds these entries, making it possible
for 8>9 upgrades of ARM systems on Alibaba cloud.

@jinkkkang jinkkkang closed this Aug 14, 2024
@jinkkkang
Copy link
Contributor Author

ok, commit updated.

@jinkkkang jinkkkang reopened this Aug 19, 2024
@jinkkkang
Copy link
Contributor Author

Incorrect operation closed PR, it has been reopened, please merge it If there are no other issues @MichalHe

@pirat89
Copy link
Member

pirat89 commented Aug 19, 2024

@jinkkkang that's unfortunate. I am now discussing whether we could make this PR to the upcoming release as you missed already the deadline for the changes. The closed PR slipped through our fingers. Also note that the commit is still not updated. But we will update the msg during the merge. Note that all PRs merged after friday are already going by default to May 2025 release.

@pirat89 pirat89 merged commit fbc38d4 into oamg:master Aug 19, 2024
35 checks passed
@pirat89 pirat89 modified the milestones: 8.10/9.5, 8.10/9.6 Aug 19, 2024
@pirat89 pirat89 added the changelog-checked The merger/reviewer checked the changelog draft document and updated it when relevant label Nov 14, 2024
yuravk pushed a commit to yuravk/leapp-repository that referenced this pull request Nov 26, 2024
Since leapp's RHUI mechanism filters setups based on the architecture of the source system,
it was not possible to upgrade of ARM-based RHEL systems on Alibaba cloud as there
were no ARM entries in RHUI_SETUPS. This patch adds these entries, making it possible
for EL 8 -> 9 upgrades of ARM systems on Alibaba cloud.

(cherry picked from commit fbc38d4)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog-checked The merger/reviewer checked the changelog draft document and updated it when relevant
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants