-
Notifications
You must be signed in to change notification settings - Fork 148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rhui setups support alibaba cloud for arm64 #1277
Conversation
Thank you for contributing to the Leapp project!Please note that every PR needs to comply with the Leapp Guidelines and must pass all tests in order to be mergeable.
Packit will automatically schedule regression tests for this PR's build and latest upstream leapp build.
Note that first time contributors cannot run tests automatically - they need to be started by a reviewer. It is possible to schedule specific on-demand tests as well. Currently 2 test sets are supported,
See other labels for particular jobs defined in the Please open ticket in case you experience technical problem with the CI. (RH internal only) Note: In case there are problems with tests not being triggered automatically on new PR/commit or pending for a long time, please contact leapp-infra. |
/packit copr-build |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tests are passing and code-wise the patch looks fine.
@jinkkkang Could you maybe provide a better commit message, please? Something like
|
ok, commit updated. |
Incorrect operation closed PR, it has been reopened, please merge it If there are no other issues @MichalHe |
@jinkkkang that's unfortunate. I am now discussing whether we could make this PR to the upcoming release as you missed already the deadline for the changes. The closed PR slipped through our fingers. Also note that the commit is still not updated. But we will update the msg during the merge. Note that all PRs merged after friday are already going by default to May 2025 release. |
Since leapp's RHUI mechanism filters setups based on the architecture of the source system, it was not possible to upgrade of ARM-based RHEL systems on Alibaba cloud as there were no ARM entries in RHUI_SETUPS. This patch adds these entries, making it possible for EL 8 -> 9 upgrades of ARM systems on Alibaba cloud. (cherry picked from commit fbc38d4)
rhui(alibaba): add ARM RHEL8 and RHEL9 setup entries
Since leapp's RHUI mechanism filters setups based on the architecture of the source system,
it was not possible to upgrade of ARM-based RHEL systems on Alibaba cloud as there
were no ARM entries in RHUI_SETUPS. This patch adds these entries, making it possible
for 8>9 upgrades of ARM systems on Alibaba cloud.
related jira: https://issues.redhat.com/browse/RHEL-53181