Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cephvolumescan: Ceph container names change prevents upgrade due to inhibitwhenluks #1188

Closed
wants to merge 1 commit into from

Conversation

asm0deuz
Copy link
Contributor

@asm0deuz asm0deuz commented Mar 8, 2024

Container names created by cephadm are now named ceph-{fsid}-osd-XX while in the past it was just
ceph-osd-XX. As the ceph-volume command cannot be run in an OSD container, it cannot detect if only
ceph OSDs are encrypted.

Fixes: https://issues.redhat.com/browse/RHEL-28647

Container names created by cephadm are now named
ceph-{fsid}-osd-XX while in the past it was just
ceph-osd-XX. It fixes that container name change.

Fixes: https://issues.redhat.com/browse/RHEL-28647

Signed-off-by: Teoman ONAY <[email protected]>
Copy link

github-actions bot commented Mar 8, 2024

Thank you for contributing to the Leapp project!

Please note that every PR needs to comply with the Leapp Guidelines and must pass all tests in order to be mergeable.
If you want to request a review or rebuild a package in copr, you can use following commands as a comment:

  • review please @oamg/developers to notify leapp developers of the review request
  • /packit copr-build to submit a public copr build using packit

Packit will automatically schedule regression tests for this PR's build and latest upstream leapp build. If you need a different version of leapp, e.g. from PR#42, use /packit test oamg/leapp#42
Note that first time contributors cannot run tests automatically - they will be started by a reviewer.

It is possible to schedule specific on-demand tests as well. Currently 2 test sets are supported, beaker-minimal and kernel-rt, both can be used to be run on all upgrade paths or just a couple of specific ones.
To launch on-demand tests with packit:

  • /packit test --labels kernel-rt to schedule kernel-rt tests set for all upgrade paths
  • /packit test --labels beaker-minimal-8.10to9.4,kernel-rt-8.10to9.4 to schedule kernel-rt and beaker-minimal test sets for 8.10->9.4 upgrade path

See other labels for particular jobs defined in the .packit.yaml file.

Please open ticket in case you experience technical problem with the CI. (RH internal only)

Note: In case there are problems with tests not being triggered automatically on new PR/commit or pending for a long time, please contact leapp-infra.

@pirat89
Copy link
Member

pirat89 commented Mar 8, 2024

@asm0deuz hi, thank you for the contribution, however it already duplicates #1180. Follow please #1180 for more info.

@pirat89 pirat89 closed this Mar 8, 2024
@asm0deuz asm0deuz deleted the ceph-osd-name branch March 8, 2024 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants