Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the reboot required text more visible in the console output #1173

Merged
merged 1 commit into from
Apr 22, 2024
Merged

Make the reboot required text more visible in the console output #1173

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions commands/upgrade/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,6 +113,11 @@ def upgrade(args, breadcrumbs):

if workflow.failure:
sys.exit(1)
elif not args.resume:
sys.stdout.write(
'Reboot the system to continue with the upgrade.'
' This might take a while depending on the system configuration.\n'
Copy link
Member

@fernflower fernflower Apr 22, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: Could we please not start the next sentence with a whitespace, but rather finish the previous one with it? Other messages try to follow that style and imho it's easier to read through.

Reboot the system to continue with the upgrade. '
'This might take a while depending on the system configuration.\n'

Copy link
Member

@pirat89 pirat89 Apr 22, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tbh, I prefer this style (whitespace at the start instead of at the end) more and it can be found on many places (usually where I worked). So currently we have actually mixture of both styles in the project. In case we want to unify this, we should discuss it and in such a case put it to coding guidelines. I understand it's just matter of taste so I am not against the discussion in such a case. Keeping the current state.

)


def register(base_command):
Expand Down
Loading