Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce the checkmptctl actor #1141

Closed
wants to merge 1 commit into from
Closed

Conversation

bessonc
Copy link

@bessonc bessonc commented Nov 7, 2023

Raise an inhibitor if the mptctl is loaded and in use, and reports the userspace processes which use it.
The suggested patch is not ideal and could be refactored as it adds another inhibitor for the same problem reported by the CheckDetectedDevicesAndDrivers actor. This is essentially to share the logic in pure python, without any additional requirement.

Fixes Red Hat issue #RHEL-15894

Outputs:

Upgrade has been inhibited due to the following problems:
    1. Inhibitor: Leapp detected loaded kernel drivers which have been removed in RHEL 8. Upgrade cannot proceed.
    2. Inhibitor: Detected processes that are using mptctl.
Consult the pre-upgrade report for details and possible remediation.
----------------------------------------
Risk Factor: high (inhibitor)
Title: Detected processes that are using mptctl.
Summary: Leapp detected that the following processes are using the mptctl kernel module which will be removed in RHEL 8:
20914: python -c f=open('/dev/mptctl','r');import time;time.sleep(300) 
14348: python -c f=open('/dev/mptctl','r');import time;time.sleep(300) 
Remediation: [hint] Stop this application or the service that runs this process.
Key: 66e1a0da39c67d3495587ed2d1bd8e810e41288d
----------------------------------------

Copy link

github-actions bot commented Nov 7, 2023

Thank you for contributing to the Leapp project!

Please note that every PR needs to comply with the Leapp Guidelines and must pass all tests in order to be mergeable.
If you want to request a review or rebuild a package in copr, you can use following commands as a comment:

  • review please @oamg/developers to notify leapp developers of the review request
  • /packit copr-build to submit a public copr build using packit

Packit will automatically schedule regression tests for this PR's build and latest upstream leapp build. If you need a different version of leapp from PR#42, use /packit test oamg/leapp#42

It is possible to schedule specific on-demand tests as well. Currently 2 test sets are supported, beaker-minimal and kernel-rt, both can be used to be run on all upgrade paths or just a couple of specific ones.
To launch on-demand tests with packit:

  • /packit test --labels kernel-rt to schedule kernel-rt tests set for all upgrade paths
  • /packit test --labels beaker-minimal-8.9to9.3,kernel-rt-8.9to9.3 to schedule kernel-rt and beaker-minimal test sets for 8.9->9.3 upgrade path

[Deprecated] To launch on-demand regression testing public members of oamg organization can leave the following comment:

  • /rerun to schedule basic regression tests using this pr build and latest upstream leapp build as artifacts
  • /rerun 42 to schedule basic regression tests using this pr build and leapp*PR42* as artifacts
  • /rerun-sst to schedule sst tests using this pr build and latest upstream leapp build as artifacts
  • /rerun-sst 42 to schedule sst tests using this pr build and leapp*PR42* as artifacts

Please open ticket in case you experience technical problem with the CI. (RH internal only)

Note: In case there are problems with tests not being triggered automatically on new PR/commit or pending for a long time, please contact leapp-infra.

Copy link
Member

@pirat89 pirat89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change is connected to RHEL bug ticket, so for now I set the blocker for merge as it cannobe merged until we have agreement with QE that this change could be added or not to the release. Also not sure about the solution, we will get to it later. This ticket has not been reviewed yet.

@pirat89 pirat89 added the bug Something isn't working label Nov 7, 2023
@mkluson
Copy link
Member

mkluson commented Nov 22, 2023

Hi there, as we agreed in the bug (https://issues.redhat.com/browse/RHEL-15894) this issue will be addressed by KCS. Closing this PR

@mkluson mkluson closed this Nov 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants