-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add autocomplete search #233
base: content
Are you sure you want to change the base?
Conversation
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/oacore/next/qcz0lsn80 |
@viktor-yakubiv can you please help me out here? It would be nice if you can review and tell me how it should look like. So I can style it properly (if needed) |
I hope the following guide from the Material Design will be useful for you. It may look hard in the implementation but there is a reasoning behind. Icons visual size is 16x16 pixels when the actual SVG file is 24x24. This is because of visual balancing: if you have a square next to the circle, to make it look visually the same the square should be 16 pixels sized when the circle diameter should be about 20 pixels. Because of combining different shapes, we make icons 24x24 but always add The button clickable area should be big enough to let mobile users easily touch it, that is why buttons are at least 32 pixels but iconic ones are 40-pixel circles. I am not saying you have something wrong with spacing because I haven't checked. Here, I wanted to say that the 'clear button' should be a circle 40x40 but the icon should stay where it is. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the visual look overall 👍 However, I have some behavioural remarks:
- when I type something and unfocus the input, the form is submitted
- once I pressed on the clear icon after typing, the input became unfocussed and the forms submitted
I did not check the code because I think you are aware of it.
7db66ed
to
f79cfb0
Compare
f79cfb0
to
dfee0b7
Compare
dfee0b7
to
9314f4f
Compare
9314f4f
to
fe17633
Compare
@viktor-yakubiv Thanks for the image. I think I managed to do it. (I may be one or two pixels off but it should be fine). Can you please have a look? |
000f441
to
3601b9a
Compare
1ccbc92
to
3344706
Compare
d4956a8
to
71b2cf1
Compare
f948647
to
5c6d6d2
Compare
No description provided.