Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CORE-4730: linking issue (#1030) #1031

Merged
merged 1 commit into from
Nov 30, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions data/home.yml
Original file line number Diff line number Diff line change
Expand Up @@ -132,7 +132,7 @@ partnerProjects:
- logo: /images/partners/ukcorr.png
users:
- title: |
**Companies** using CORE
[Companies](/about/endorsements#enterprise-companies) using CORE
testimonial:
id: gareth-malcolm
content: |
Expand All @@ -156,9 +156,9 @@ users:
alt: "naver"
action:
caption: Show all
url: '/about/endorsements'
url: '/about/endorsements#enterprise-companies'
- title: |
**Academic** institution using CORE
[Academic](/about/endorsements#academic-institutions) institution using CORE
testimonial:
id: kathleen-shearer
content: |
Expand All @@ -183,9 +183,9 @@ users:
full: true
action:
caption: Show all
url: '/about/endorsements'
url: '/about/endorsements#academic-institutions'
- title: |
**Partner** projects
[Partner](/about/endorsements#partner-projects) projects
testimonial:
id: ben-johnson
content: |
Expand Down Expand Up @@ -214,7 +214,7 @@ users:
background: true
action:
caption: Show all
url: '/about/endorsements'
url: '/about/endorsements#partner-projects'

covid-19-notice: |
Stay up to date with the latest Open Access research
Expand Down
27 changes: 0 additions & 27 deletions pages/index.jsx
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,6 @@ import {
JoinItem,
TestimonialList,
TestimonialItem,
TestimonialCard,
ServicesList,
ServiceItem,
Layout,
Expand Down Expand Up @@ -88,19 +87,6 @@ const Hero = ({
</div>
)

const PartnerProjectsList = () => (
<ul className={styles.sectionPartnersList}>
{page.partnerProjects.children.map(({ logo }, index) => (
<TestimonialCard
// eslint-disable-next-line react/no-array-index-key
key={index}
imgUrl={logo}
className={styles.sectionPartnersListItem}
/>
))}
</ul>
)

const IndexPage = () => {
const [searchValue, setSearchValue] = useState('')

Expand Down Expand Up @@ -190,19 +176,6 @@ const IndexPage = () => {
</Button>
</div>
</Section>
<Section className={styles.sectionPartners}>
<h3 className={styles.title}>{page.partnerProjects.title}</h3>
<PartnerProjectsList />
<div className={styles.actionButton}>
<Button
variant="outlined"
tag="a"
href={page.partnerProjects.action}
>
{page.partnerProjects.actionLabel}
</Button>
</div>
</Section>
</Layout>
<Section className={styles.partners}>
{page.users.map((item) => (
Expand Down
8 changes: 6 additions & 2 deletions pages/index.module.scss
Original file line number Diff line number Diff line change
Expand Up @@ -217,7 +217,7 @@
display: flex;
justify-content: space-between;
gap: 35px;
margin-bottom: 24px;
margin-bottom: 32px;
.testimonial-item {
width: 75%;
}
Expand All @@ -229,8 +229,12 @@
font-weight: 500;
line-height: 130%;
cursor: unset;
&:hover {
a {
text-decoration: none;
color: #b75400;
&:hover {
text-decoration: none;
}
}
}
}
Expand Down
Loading