WIP pull request - ERC viewable as galley #1
Conversation
…uring submission process
tomniers
changed the title
| @@ -0,0 +1,15 @@ | |||
| { | |||
| "short_name": "React App", | |||
There was a problem hiding this comment.
Change short name and name to something more reasonable.
There was a problem hiding this comment.
@NJaku01 Can you take care of it so that it is done in general for the build?
There was a problem hiding this comment.
I have adapted it in my fork, the changes will be available in the build with the next release.
ojsErcPlugin.inc.php
Outdated
| $manifestNew = $baseUrl . '/' . $this->getPluginPath() . '/build' . substr($manifestOld[0], 1); | ||
| $adaptedManifest = str_replace($manifestOld[0], $manifestNew, $adaptedLogo); | ||
|
|
||
| preg_match('"\.\/config\.js"', $readHtmlFile, $configOld); |
There was a problem hiding this comment.
Can you encapsulate this in a function? Looks very repetitive.
There was a problem hiding this comment.
Yeah is done here: a23c335
| @@ -0,0 +1,10 @@ | |||
| <?xml version="1.0" encoding="UTF-8"?> | |||
| <!DOCTYPE version SYSTEM "../../../lib/pkp/dtd/pluginVersion.dtd"> | |||
There was a problem hiding this comment.
This path does not exist in this repository - I assume that is not a problem? Or exchange the dtd URL with a correct online URL?
There was a problem hiding this comment.
This is a default of the ojs repository. In the OJS repository the path leads to the plugin version. So I think its correct.
version.xml
Outdated
| <version> | ||
| <application>ojs-erc-plugin</application> | ||
| <type>plugins.generic</type> | ||
| <release>0.1.0.0</release> |
There was a problem hiding this comment.
Are 4 digits required for the version, or can we also stick to major.minor.bugfix ?
There was a problem hiding this comment.
No we can also stick to 3 digits, the corresponding commit can be found here: eaea77a
version.xml
Outdated
| <application>ojs-erc-plugin</application> | ||
| <type>plugins.generic</type> | ||
| <release>0.1.0.0</release> | ||
| <date>2019-05-15</date> |
There was a problem hiding this comment.
Please start the notes for creating releases and document how this file needs to be updated.
There was a problem hiding this comment.
The notes are now available via a description in the README.md and the CHANGELOG.md. The corresponding commit can be found here: eaea77a
Concerning your question, the |
@nuest
Here my first steps with the plugin!