Initial support for testing #9
Conversation
More to come
| <dependency> | ||
| <groupId>com.github.tomakehurst</groupId> | ||
| <artifactId>wiremock</artifactId> | ||
| <version>1.58</version> |
There was a problem hiding this comment.
Why not put this version number with the others in properties?
There was a problem hiding this comment.
I go back and forth. If it’s version used by a number of jar files that are related, then I like using the interpolation. If it’s a single jar, then it’s yet another level of indirection.
Regardless, good to see…
On May 18, 2016, at 10:59 AM, Matt Overstreet [email protected] wrote:
In pom.xml #9 (comment):
@@ -30,6 +31,18 @@
jetty-proxy
${jetty.version}
<groupId>junit</groupId><artifactId>junit</artifactId><scope>test</scope><version>${junit.version}</version><groupId>com.github.tomakehurst</groupId><artifactId>wiremock</artifactId><version>1.58</version>—
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub https://github.com/o19s/grand_central/pull/9/files/36fa649c8da1d0d74db04350b6894abcc4028e73#r63719588
Eric Pugh | Principal | OpenSource Connections, LLC | 434.466.1467 | http://www.opensourceconnections.com http://www.opensourceconnections.com/ | My Free/Busy http://tinyurl.com/eric-cal
Co-Author: Apache Solr Enterprise Search Server, 3rd Ed https://www.packtpub.com/big-data-and-business-intelligence/apache-solr-enterprise-search-server-third-edition-raw
This e-mail and all contents, including attachments, is considered to be Company Confidential unless explicitly stated otherwise, regardless of whether attachments are marked as such.
There was a problem hiding this comment.
I see your point on level of indirection, but it is convenient to have all version numbers together. If we include them with each dependency then you're crawling through each dependency's XML block a) looking for the right block and b) looking for the version element.
Fortunately our number of dependencies is small so it isn't that big of a task. I'm open for either approach. @epugh has a point.
|
This looks awesome @omnifroodle let me know if I can help. |
|
So, I had to copy |
|
The example config file under the root is a reference for people running their own Grand Central. For testing a file under resources makes sense. |
|
What is the “minimum” required? I could go through and try and prune the example one. Right now the unit test passes, though I don’t see any asserts. And I’m not sure it passes because of the great big mocking of the actually call to Kubernetes!
Eric Pugh | Principal | OpenSource Connections, LLC | 434.466.1467 | http://www.opensourceconnections.com http://www.opensourceconnections.com/ | My Free/Busy http://tinyurl.com/eric-cal |
More to come..
This approach to testing uses a disposable web server to impersonate kubernetes(wire mock). To make this simpler I've setup the action I'm testing to allow for http or https (with https as the default).
Also, why does Java not have multiline strings 😦