o1vm/mips: decrease scratch size by 40% #2815
Open
+33
−46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dannywillems
force-pushed
the
o1vm/batch-inversion
branch
from
4122619
to
8be102a
Compare
dannywillems
force-pushed
the
o1vm/decrease-scratch-size
branch
from
690db8f
to
d54afa6
Compare
dannywillems
changed the title
dannywillems
force-pushed
the
o1vm/batch-inversion
branch
from
8be102a
to
4d82c40
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## o1vm/batch-inversion #2815 +/- ##
========================================================
- Coverage 72.15% 72.15% -0.01%
========================================================
Files 256 256
Lines 60042 60042
========================================================
- Hits 43326 43322 -4
- Misses 16716 16720 +4 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
dannywillems
force-pushed
the
o1vm/batch-inversion
branch
from
4d82c40
to
a11a350
Compare
In addition to that, moving the values SCRATCH_SIZE and SCRATCH_SIZE_INVERSE into column.rs
It seems that most of the state was empty.
dannywillems
force-pushed
the
o1vm/decrease-scratch-size
branch
from
d54afa6
to
796267d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems that most of the state was empty. See this comment