Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

o1vm/riscv32: implement div_signed #2799

Open
wants to merge 1 commit into
base: dw/o1vm/riscv-remove-mul-hi-lo
Choose a base branch
from

Conversation

dannywillems
Copy link
Member

No description provided.

Comment on lines +495 to +499
let x: u32 = (*x).try_into().unwrap();
let y: u32 = (*y).try_into().unwrap();
let res = ((x as i32) / (y as i32)) as u32;
let res = res as u64;
self.write_column(position, res);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
let x: u32 = (*x).try_into().unwrap();
let y: u32 = (*y).try_into().unwrap();
let res = ((x as i32) / (y as i32)) as u32;
let res = res as u64;
self.write_column(position, res);
let x: i32 = (*x).try_into().unwrap();
let y: i32 = (*y).try_into().unwrap();
let res = x / y;
let res = res as u64;
self.write_column(position, res);

Copy link

codecov bot commented Nov 21, 2024

Codecov Report

Attention: Patch coverage is 0% with 21 lines in your changes missing coverage. Please review.

Project coverage is 71.96%. Comparing base (9a8de63) to head (250bce5).

Files with missing lines Patch % Lines
o1vm/src/interpreters/riscv32im/witness.rs 0.00% 13 Missing ⚠️
o1vm/src/interpreters/riscv32im/constraints.rs 0.00% 8 Missing ⚠️
Additional details and impacted files
@@                        Coverage Diff                         @@
##           dw/o1vm/riscv-remove-mul-hi-lo    #2799      +/-   ##
==================================================================
- Coverage                           71.98%   71.96%   -0.03%     
==================================================================
  Files                                 255      255              
  Lines                               59967    59988      +21     
==================================================================
- Hits                                43170    43168       -2     
- Misses                              16797    16820      +23     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants