Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

o1vm/riscv32: implement M type instruction Mul #2794

Open
wants to merge 1 commit into
base: dw/riscv32-impl-mul-lo
Choose a base branch
from

Conversation

dannywillems
Copy link
Member

No description provided.

@@ -2146,7 +2146,17 @@ pub fn interpret_mtype<Env: InterpreterEnv>(env: &mut Env, instr: MInstruction)

match instr {
MInstruction::Mul => {
unimplemented!("Mul")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it would be nice to comment the implementation from https://msyksphinz-self.github.io/riscv-isadoc/html/rvm.html

Copy link

codecov bot commented Nov 21, 2024

Codecov Report

Attention: Patch coverage is 0% with 12 lines in your changes missing coverage. Please review.

Project coverage is 71.93%. Comparing base (f707007) to head (e0c1e89).
Report is 1 commits behind head on dw/riscv32-impl-mul-lo.

Files with missing lines Patch % Lines
o1vm/src/interpreters/riscv32im/interpreter.rs 0.00% 12 Missing ⚠️
Additional details and impacted files
@@                    Coverage Diff                     @@
##           dw/riscv32-impl-mul-lo    #2794      +/-   ##
==========================================================
- Coverage                   71.97%   71.93%   -0.04%     
==========================================================
  Files                         255      255              
  Lines                       59984    60019      +35     
==========================================================
+ Hits                        43172    43175       +3     
- Misses                      16812    16844      +32     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants