Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add support for sanitizing slash commands mentions #40

Merged
merged 3 commits into from
Aug 26, 2024

Conversation

Lexedia
Copy link
Member

@Lexedia Lexedia commented Aug 16, 2024

Description

This also fixes an issue with emojis sanitization, since <:hi:1234> would be interpreted as <literalemojihi:1234> by discord

Connected issues & potential other potential problems

If changes in PR are connected to other issues or are affecting code in other parts of framework
(e.g. in main package or any other subpackage) make sure to link issue/PR and describe said problem

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • Ran dart analyze or make analyze and fixed all issues
  • Ran dart format --set-exit-if-changed -l 160 ./lib or make format and fixed all issues
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works

@Lexedia Lexedia self-assigned this Aug 16, 2024
@Lexedia Lexedia added the enhancement New feature or request label Aug 16, 2024
@Lexedia Lexedia added this to the 4.2.0 milestone Aug 16, 2024
l7ssha
l7ssha previously approved these changes Aug 23, 2024
lib/src/utils/sanitizer.dart Outdated Show resolved Hide resolved
lib/src/utils/sanitizer.dart Outdated Show resolved Hide resolved
lib/src/utils/sanitizer.dart Outdated Show resolved Hide resolved
@Lexedia Lexedia merged commit 20443f1 into dev Aug 26, 2024
3 checks passed
@Lexedia Lexedia deleted the feat/sanitize-commands branch August 26, 2024 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
No open projects
Status: Ready for deploy
Development

Successfully merging this pull request may close these issues.

3 participants