Correctly decode emoji data as UTF-8 (#11)

* Correctly decode emoji data as UTF-8 * Add tests
nyxx-discord · Sep 11, 2023 · 3847d38 · 3847d38
1 parent 5906fb1
commit 3847d38
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 1 deletion.
diff --git a/lib/src/emoji.dart b/lib/src/emoji.dart
@@ -81,7 +81,7 @@ Future<List<EmojiDefinition>> getEmojiDefinitions() async {
     return _cachedEmojiDefinitions!;
   } else {
     final response = await http.get(_emojiDefinitionsUrl);
-    final data = jsonDecode(response.body)['emojiDefinitions'];
+    final data = jsonDecode(utf8.decode(response.bodyBytes))['emojiDefinitions'];
 
     _cachedAt = DateTime.timestamp();
     return _cachedEmojiDefinitions = [

diff --git a/test/integration/emoji_test.dart b/test/integration/emoji_test.dart
@@ -7,4 +7,10 @@ void main() {
 
     expect(emojis, isNotEmpty);
   });
+
+  test('getEmojiDefinitions correcly decodes emojis', () async {
+    final emoji = (await getEmojiDefinitions()).singleWhere((element) => element.primaryName == 'heart');
+
+    expect(emoji.surrogates, equals('❤️'));
+  });
 }