Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

properly censor the token when connecting #726

Merged
merged 1 commit into from
Nov 1, 2024
Merged

Conversation

Lexedia
Copy link
Member

@Lexedia Lexedia commented Oct 30, 2024

Description

title

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • Ran dart analyze or make analyze and fixed all issues
  • Ran dart format --set-exit-if-changed -l 160 ./lib or make format and fixed all issues
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works

Copy link
Member

@abitofevrything abitofevrything left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would prefer to just log the connection information after plugins have run their beforeConnect (where the Logging plugin sets up token censoring).

This can be done by moving the logging lines to the inside of the _doConnect callback parameter IIRC.

@l7ssha l7ssha added this to the 6.5.1 milestone Oct 30, 2024
@l7ssha l7ssha added the bug Something isn't working label Oct 30, 2024
@Lexedia Lexedia force-pushed the fix/properly-censor-token branch from ee7039b to cccf3b8 Compare November 1, 2024 17:56
@l7ssha l7ssha merged commit 3cd8c77 into main Nov 1, 2024
5 checks passed
@l7ssha l7ssha deleted the fix/properly-censor-token branch November 1, 2024 22:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants