Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Correctly include query parameters #653

Merged
merged 1 commit into from
Apr 25, 2024
Merged

fix: Correctly include query parameters #653

merged 1 commit into from
Apr 25, 2024

Conversation

Lexedia
Copy link
Member

@Lexedia Lexedia commented Apr 25, 2024

Description

Resolve nyxx_extensions#37

Connected issues & other potential problems

See above

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • Ran dart analyze or make analyze and fixed all issues
  • Ran dart format --set-exit-if-changed -l 160 ./lib or make format and fixed all issues
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works

@abitofevrything abitofevrything added the bug Something isn't working label Apr 25, 2024
@abitofevrything abitofevrything added this to the 6.3.0 milestone Apr 25, 2024
@abitofevrything abitofevrything merged commit f2c33ce into dev Apr 25, 2024
7 checks passed
@abitofevrything abitofevrything deleted the fix/cdn-query-params branch April 25, 2024 13:12
abitofevrything pushed a commit that referenced this pull request Jul 7, 2024
@Lexedia @abitofevrything
Correctly include query parameters (#653)
f4a9243
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abitofevrything abitofevrything abitofevrything approved these changes

Assignees

@Lexedia Lexedia

Labels
bug Something isn't working
Projects
No open projects
nyxx roadmap
Status: Done
Milestone
6.3.0
Development

Successfully merging this pull request may close these issues.
2 participants
@Lexedia @abitofevrything