This repository has been archived by the owner on Mar 17, 2021. It is now read-only.
Rename folder functions' arguments names to match Grafana API #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tonglil
reviewed
Jun 3, 2020
There was a problem hiding this comment.
Thank you, this looks good to me.
Would you be able to add a new function and corresponding test for FolderByUid please?
https://grafana.com/docs/grafana/latest/http_api/folder/#get-folder-by-uid
If not, if you can resolve the conflict then we can merge it.
tonglil
added
size/XS
Sure thing! I will update the PR this week. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR renames
idandnametouidandtitleinUpdateFolderandDeleteFoldermethods.It also sets
overwritetotruewhen updating a folder - otherwise it's a noop as we don't provide the current version of the folder.