Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hopefully we don't need this #638

Merged
merged 1 commit into from
Nov 10, 2024
Merged

hopefully we don't need this #638

merged 1 commit into from
Nov 10, 2024

Conversation

martincai8
Copy link
Contributor

Description

Other considerations

Copy link

github-actions bot commented Nov 10, 2024

Visit the preview URL for this PR (updated for commit 4d5f389):

https://nwplus-ubc--pr638-peer-judging-hotfix-sbbgcnyt.web.app

(expires Sun, 17 Nov 2024 17:36:57 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 8c7ea898e009e43455645bc310bcbccfc0f87e48

@DonaldKLee
Copy link
Member

can i merge this to dev? we might need this AHAHHA

@martincai8
Copy link
Contributor Author

we needed this

@DonaldKLee DonaldKLee self-requested a review November 10, 2024 19:23
Copy link
Member

@DonaldKLee DonaldKLee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm so cracked

@DonaldKLee DonaldKLee merged commit 0ace239 into dev Nov 10, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants