Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Title and favicon change event on webview #74

Open
wants to merge 3 commits into
base: nw22
Choose a base branch
from
Open

Title and favicon change event on webview #74

wants to merge 3 commits into from

Conversation

janRucka
Copy link
Contributor

@janRucka janRucka commented Mar 7, 2017 •
edited
Loading

This was referenced Mar 7, 2017
Closed
Closed
@rogerwang rogerwang force-pushed the nw21 branch 2 times, most recently from 7da209b to c286db2 Compare March 9, 2017 04:39
rogerwang
rogerwang requested changes Mar 9, 2017
View reviewed changes
extensions/browser/guest_view/web_view/web_view_guest.h Outdated
int32_t level,
const base::string16& message,
int32_t line_no,
const base::string16& source_id) final;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please don't touch white spaces for no reason.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point, done by mistake.

rogerwang pushed a commit that referenced this pull request Mar 11, 2017
@kainino0x
Expand 2 Linux/NVIDIA workarounds to Android/NVIDIA
93add42 
pack_parameters_workaround_with_pack_buffer fixes
conformance2/reading/read-pixels-pack-parameters.html

unpack_alignment_workaround_with_unpack_buffer fixes
conformance2/textures/misc/tex-unpack-params.html

BUG=698926
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2735823003
Cr-Commit-Position: refs/heads/master@{#455394}
(cherry picked from commit 08e70dd)

Review-Url: https://codereview.chromium.org/2737243002 .
Cr-Commit-Position: refs/branch-heads/3029@{#74}
Cr-Branched-From: 939b32e-refs/heads/master@{#454471}
@janRucka
Copy link
Contributor Author

Updated to current nw21.
No whitespaces touching.

@rogerwang rogerwang force-pushed the nw21 branch 3 times, most recently from f1e4ded to 4fd96a3 Compare April 6, 2017 01:18
GnorTech pushed a commit that referenced this pull request Apr 26, 2017
Incrementing VERSION to 59.0.3071.16
15634ae 
Cr-Commit-Position: refs/branch-heads/3071@{#74}
Cr-Branched-From: a106f0a-refs/heads/master@{#464641}
@janRucka janRucka changed the base branch from nw21 to nw22 May 5, 2017 13:57
@janRucka janRucka mentioned this pull request May 5, 2017
Open
@rogerwang rogerwang force-pushed the nw22 branch 4 times, most recently from 65748ff to 90fd209 Compare May 10, 2017 06:28
GnorTech pushed a commit that referenced this pull request Aug 5, 2017
@kojiishi
Merge 3163: Adjust the mid-word-break heuristic limit to 4em for Emoj…
d2c58dc 
…i ZWJ sequence

Mid-word-break algorithm kicks in when CSS properties such as
'word-wrap: break-word' is used. Logically speaking, we should layout
as normal, and break words if overflow occurs.

However, Blink has 2em heuristic limit because of the performance
problem in certain cases. This means Blink measures characters that go
beyond the right edge only up to 2em before it starts mid-word-break.
See the previous CL[1] for more details.

This patch adjusts it to 4em. The longest common ligature is Emoji ZWJ
sequence, and its v5.0[2] can ligate 4 Emoji into 1 at maximum. To
handle this, 3em overflow is needed, and 1em for a rainy day fund.

[1] r403830, https://codereview.chromium.org/2077313002
[2] http://unicode.org/emoji/charts/emoji-zwj-sequences.html

[email protected]

(cherry picked from commit 14ec221)

Bug: 746222
Change-Id: Ic58b58716502f4ae9a06c1e91d2f5de944bc7978
Reviewed-on: https://chromium-review.googlesource.com/581249
Reviewed-by: Dominik Röttsches <[email protected]>
Commit-Queue: Koji Ishii <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#488813}
Reviewed-on: https://chromium-review.googlesource.com/587705
Reviewed-by: Koji Ishii <[email protected]>
Cr-Commit-Position: refs/branch-heads/3163@{#74}
Cr-Branched-From: ff259ba-refs/heads/master@{#488528}
GnorTech pushed a commit that referenced this pull request Sep 14, 2017
@galmacky
Fix for Japanese keyboards
7b9f09c 
Japanese keyboards do not finish composition when we restore the deleted
text. Then some keyboards call setComposingText([text], 1) again which
moves the cursor before the restored text, and some keyboards do not
respond at all and therefore later composition change moves the cursor
before the restored text.

It seems that all the keyboard apps I tested calmly respond to the
finishComposingText() call, probably because it gets the call in various
situations such as focus loss.

BUG=758443

(cherry picked from commit 08ed69a)

Change-Id: I752d9d86053a923d7ffc4ef248d088ca991aeae1
Reviewed-on: https://chromium-review.googlesource.com/636107
Commit-Queue: Changwan Ryu <[email protected]>
Reviewed-by: Ted Choc <[email protected]>
Reviewed-by: Alexandre Elias <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#500122}
Reviewed-on: https://chromium-review.googlesource.com/656515
Reviewed-by: Changwan Ryu <[email protected]>
Cr-Commit-Position: refs/branch-heads/3202@{#74}
Cr-Branched-From: fa6a5d8-refs/heads/master@{#499098}
GnorTech pushed a commit that referenced this pull request Oct 27, 2017
@kerrnel90
macOS Sandbox: Fix timezone information on 10.13.
1e7395d 
This fixes the sandbox rules to access timezone information specifically
on 10.13.

Bug: 773532
Change-Id: I32dc858a9607b10aa7db4df464a627d02d89b683
Reviewed-on: https://chromium-review.googlesource.com/722203
Reviewed-by: Robert Sesek <[email protected]>
Commit-Queue: Greg Kerr <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#509436}(cherry picked from commit 0af01a8)
Reviewed-on: https://chromium-review.googlesource.com/728619
Reviewed-by: Greg Kerr <[email protected]>
Cr-Commit-Position: refs/branch-heads/3239@{#74}
Cr-Branched-From: adb61db-refs/heads/master@{#508578}
rogerwang pushed a commit that referenced this pull request Jan 29, 2018
@alexkozy
[DevTools] fixed coverage in Node.js frontend
1b1313f 
We should not check for resource tree model when inspecting Node.js
target.

[email protected]
[email protected]

(cherry picked from commit 8af9bb9)

Bug: chromium:787754
Change-Id: I04503a249acc05182524da40f83765e6ad7c37a5
Reviewed-on: https://chromium-review.googlesource.com/881468
Commit-Queue: Aleksey Kozyatinskiy <[email protected]>
Reviewed-by: Dmitry Gozman <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#531342}
Reviewed-on: https://chromium-review.googlesource.com/884729
Reviewed-by: Aleksey Kozyatinskiy <[email protected]>
Cr-Commit-Position: refs/branch-heads/3325@{#74}
Cr-Branched-From: bc084a8-refs/heads/master@{#530369}
GnorTech pushed a commit that referenced this pull request Mar 20, 2018
@sebmarchand
Fix some tab lifetime management issues in TabLifecycleUnitSource.
ce49bf6 
Move the WebContentsObserver from TabLifeCycleUnit to TabLifeCycleUnitSource,
this allows for a better tracking of the WebContents lifetime, in some
situation a WebContents might get detached from the TabStrip and then
destroyed, which mean that we won't get a TabClosingAt notification for
this tab destruction.

Another solution would be to implement the TabStripModelObserver::TabDetachedAt
function and track the tabs which are in a detached state but this is slightly
more complex because TabDetachedAt might be called for several reasons:
- A TabDetachedAt usually come after a TabClosedAt event.
- TabDetachedAt might be followed by TabInsertedAt, or not if it get destroyed.
  because of this we won't know if we should keep the TabLifeCycleUnit for this
  WebContents around (i.e. if it'll get re-inserted in a tab strip) or destroy
  it because it's being destroyed.

Observing WebContentsObserver::WebContentsDestroyed and moving the logic that
was in TabClosingAt to this method address these issues, it's the same approach
than the one we took in TabStatsTracker.

Bug: 819352, 818454
Change-Id: Ibd3fe49b2798ade19ee781cb70eb30e52372d686
Reviewed-on: https://chromium-review.googlesource.com/952405
Commit-Queue: Sébastien Marchand <[email protected]>
Reviewed-by: Chris Hamilton <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#541540}(cherry picked from commit 70546dc)
Reviewed-on: https://chromium-review.googlesource.com/953367
Reviewed-by: Sébastien Marchand <[email protected]>
Cr-Commit-Position: refs/branch-heads/3359@{#74}
Cr-Branched-From: 66afc5e-refs/heads/master@{#540276}
rogerwang pushed a commit that referenced this pull request Apr 25, 2018
[Merge to M67] Propagate memory pressure to child processes.
e148251 
MemoryPressureMonitor (added in https://crrev.com/c/953166) polls
memory pressure when it gets CRITICAL to (1) lower memory usage by
repeatedly invoking pressure listeners and (2) sense (and notify
listeners) when pressure subsides.

However the polling only happens in the browser / WebView process,
because (1) ActivityManager.getMyMemoryState() can't be called from
isolated services, and (2) we want to poll only when Chrome is in
the foreground / there are WebView instances around.

This CL propagates pressure signals from the polling process to all
its services. That way in addition to getting pressure signals from
Android via ComponentCallbacks2, services also get signals from the
their main process.

(cherry picked from commit 9bd1a50)

Bug: 813909
Change-Id: Icef3b31106dcf432e6cdbdb0e1cdd84539dd690b
Reviewed-on: https://chromium-review.googlesource.com/992865
Reviewed-by: Daniel Cheng <[email protected]>
Reviewed-by: Bo <[email protected]>
Reviewed-by: agrieve <[email protected]>
Commit-Queue: Dmitry Skiba <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#550850}
Reviewed-on: https://chromium-review.googlesource.com/1016065
Reviewed-by: Dmitry Skiba <[email protected]>
Cr-Commit-Position: refs/branch-heads/3396@{#74}
Cr-Branched-From: 9ef2aa8-refs/heads/master@{#550428}
rogerwang pushed a commit that referenced this pull request Jun 19, 2018
Download Infobar : Fixed bugs in incognito
23e43f9 
For incognito profiles, the infobar is not being shown since
the DownloadManagerService only starts observing the download item updates
after we open download home in incognito. Fixed this bug in this CL.

Bug: 846139
Change-Id: I507c285901474ce47f09a1610639805afe3c904f
Reviewed-on: https://chromium-review.googlesource.com/1073078
Commit-Queue: Shakti Sahu <[email protected]>
Reviewed-by: Min Qin <[email protected]>
Reviewed-by: David Trainor <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#563066}(cherry picked from commit 90ca68a)
Reviewed-on: https://chromium-review.googlesource.com/1080973
Reviewed-by: Shakti Sahu <[email protected]>
Cr-Commit-Position: refs/branch-heads/3440@{#74}
Cr-Branched-From: 010ddcf-refs/heads/master@{#561733}
GnorTech pushed a commit that referenced this pull request Aug 4, 2018
Prevent null pointer dereferencing in WebRtcRemoteEventLogManager
f72dbcf 
|network_connection_tracker_| might never be set (if no profile
is loaded). In that case, it should not be dereferenced.

Bug: 866865
Change-Id: I490be08795f41908d7ac49fdcd5d8588fbea83b7
Reviewed-on: https://chromium-review.googlesource.com/1148335
Commit-Queue: Elad Alon <[email protected]>
Reviewed-by: Max Morin <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#577528}(cherry picked from commit ac6c083)
Reviewed-on: https://chromium-review.googlesource.com/1149841
Reviewed-by: Elad Alon <[email protected]>
Cr-Commit-Position: refs/branch-heads/3497@{#74}
Cr-Branched-From: 271eaf5-refs/heads/master@{#576753}
rogerwang pushed a commit that referenced this pull request Sep 15, 2018
@creis
Merge to M70: Update flag description for chrome://flags/#enable-site…
5ba1486 
…-per-process.

The "Disabled" value is legacy and confusing, since it actually means
"Default" (which is currently "Enabled" on desktop platforms).
Unfortunately, updating the label to "Default" would reset users'
preferences, which is undesirable (especially on Android).

Instead, update the description to clarify the meaning of the settings
and to point to chrome://process-internals for checking status.

Bug: 879633
Change-Id: I672f5ebe4ef75482493f0668b64d6d20144d15ed
Reviewed-on: https://chromium-review.googlesource.com/1198011
Commit-Queue: Charlie Reis <[email protected]>
Reviewed-by: Alex Moshchuk <[email protected]>
Cr-Commit-Position: refs/heads/master@{#588098}

Also merges r588601:
Fix typo in enable-site-per-process flag description.

Change-Id: Ia8d706326522a26505be7848b78fae396de99755
Reviewed-on: https://chromium-review.googlesource.com/1204732
Reviewed-by: Alex Moshchuk <[email protected]>
Commit-Queue: Charlie Reis <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#588601}
Reviewed-on: https://chromium-review.googlesource.com/1208950
Reviewed-by: Charlie Reis <[email protected]>
Cr-Commit-Position: refs/branch-heads/3538@{#74}
Cr-Branched-From: 79f7c91-refs/heads/master@{#587811}
rogerwang pushed a commit that referenced this pull request Oct 31, 2018
@pbos
Fix touchable insets for Avatar/Cast toolbar icons
ed63ea8 
An earlier refactoring set zero-insets for touchable AvatarToolbarButton
instead of insets for TOOLBAR_BUTTON. This API was confusing to use so
SetLayoutInsets was changed and renamed to SetLayoutInsetDelta to make
it easier to use. Callers no longer need to include the call to
GetLayoutInsets(TOOLBAR_BUTTON).

CastToolbarButton having incorrect ink-drops was not a regression but
has always used a 16dp icon in both touchable and non-touchable modes.
This change also calls SetInsetDelta to make up for the missing 8dp.

Bug: chromium:895519
Change-Id: I30595913dfb8a19358d198d9f4e0dbcb37993117
Reviewed-on: https://chromium-review.googlesource.com/c/1281903
Reviewed-by: Bret Sepulveda <[email protected]>
Commit-Queue: Peter Boström <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#599765}(cherry picked from commit 019423b)
Reviewed-on: https://chromium-review.googlesource.com/c/1285321
Reviewed-by: Peter Boström <[email protected]>
Cr-Commit-Position: refs/branch-heads/3578@{#74}
Cr-Branched-From: 4226ddf-refs/heads/master@{#599034}
rogerwang pushed a commit that referenced this pull request Dec 18, 2018
[iOS][MF] Fix cell with extra constraint
aaa6ec0 
Bug: 845472
Change-Id: Ibdcc5ead0e06decf0fc27914bea6801120cc77a9
Reviewed-on: https://chromium-review.googlesource.com/c/1356980
Reviewed-by: Yi Su <[email protected]>
Commit-Queue: Javier Ernesto Flores Robles <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#612656}(cherry picked from commit e11b6ae)
Reviewed-on: https://chromium-review.googlesource.com/c/1363195
Reviewed-by: Javier Ernesto Flores Robles <[email protected]>
Cr-Commit-Position: refs/branch-heads/3626@{#74}
Cr-Branched-From: d897fb1-refs/heads/master@{#612437}
rogerwang pushed a commit that referenced this pull request Feb 10, 2019
@steveanton
Handle role conflict in the standalone RTCIceTransport
f05eec2 
Bug: 926134
Change-Id: I202c76275a97d295866ea70079f95f814e6de5b6
Reviewed-on: https://chromium-review.googlesource.com/c/1443544
Commit-Queue: Steve Anton <[email protected]>
Commit-Queue: Seth Hampson <[email protected]>
Auto-Submit: Steve Anton <[email protected]>
Reviewed-by: Seth Hampson <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#627108}(cherry picked from commit f1fbab6)
Reviewed-on: https://chromium-review.googlesource.com/c/1446839
Reviewed-by: Steve Anton <[email protected]>
Cr-Commit-Position: refs/branch-heads/3683@{#74}
Cr-Branched-From: e510299-refs/heads/master@{#625896}
rogerwang pushed a commit that referenced this pull request Mar 24, 2019
@rakina
Revert "Make mouse-triggered focus use flat tree traversal"
7d66bde 
This reverts commit 169c2ef.

Reason for revert: Causes crbug.com/939546, and fix for selection seems to be non-trivial.

Original change's description:
> Make mouse-triggered focus use flat tree traversal
>
> Previously mouse-triggered focusing on an element (e.g. clicking) uses
> repeated calls of ParentOrShadowElement() instead of using flat-tree
> traversal methods, causing it to go up its shadow-including ancestors
> instead of flat-tree. This behavior is not specified, but other
> browser vendors had implemented flat-tree traversal usage for focus
> traversal.
>
> See: WICG/webcomponents#773
>
> Bug: 894931
> Change-Id: I5666c9e973480648e8e9a1774e5d6abe026aac5c
> Reviewed-on: https://chromium-review.googlesource.com/c/1455839
> Reviewed-by: Hayato Ito <[email protected]>
> Reviewed-by: Kent Tamura <[email protected]>
> Commit-Queue: Rakina Zata Amni <[email protected]>
> Cr-Commit-Position: refs/heads/master@{#629515}

[email protected],[email protected],[email protected]

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 894931, 939546
Change-Id: I215fe3f98c6117cd2bff8bd0930f3b8e380646f9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1514433
Reviewed-by: Rakina Zata Amni <[email protected]>
Reviewed-by: Kent Tamura <[email protected]>
Commit-Queue: Rakina Zata Amni <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#639420}(cherry picked from commit 5310256007c2d3a77fdf520d2eb2e1d06a04a8d3)
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1519508
Cr-Commit-Position: refs/branch-heads/3729@{#74}
Cr-Branched-From: d4a8972-refs/heads/master@{#638880}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rogerwang rogerwang rogerwang requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@janRucka @rogerwang