enable midi -> audio (re pull) #85
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The error occurs in test1.py and it's none of my bussiness! it has been days since this pull request. |
cclauss
reviewed
Dec 10, 2024
|
Not sure what happened with the CI checks here. I made #86 and cherry-picked the changes with some minor syntax updates and it seems to work. |
cclauss
approved these changes
Dec 11, 2024
|
It might be a good idea to re-add |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
recreate pull request #83
This error originates from a space: fluidsynth.py:1085:1: W293 Blank line contains whitespace, and I have removed the extra 'whitespace'.
I test my code with the latest fluidsynth release and python 3.10, and it works well.