refactor: provide changelog via injector

nvsukhanov · Mar 13, 2024 · 2493193 · 2493193
1 parent ddc6d21
commit 2493193
Show file tree

Hide file tree

Showing 6 changed files with 22 additions and 19 deletions.
diff --git a/modules/shared/ui/src/lib/changelog/changelog.component.html b/modules/shared/ui/src/lib/changelog/changelog.component.html
@@ -1,5 +1,5 @@
 <ol class="versions-list">
-    @for(versionRecord of log; track versionRecord; let last = $last; let first = $first) {
+    @for(versionRecord of changelog; track versionRecord; let last = $last; let first = $first) {
     <li class="version-record"
         [class.version-record__first]="first"
     >

diff --git a/modules/shared/ui/src/lib/changelog/changelog.component.ts b/modules/shared/ui/src/lib/changelog/changelog.component.ts
@@ -1,8 +1,8 @@
-import { ChangeDetectionStrategy, Component } from '@angular/core';
+import { ChangeDetectionStrategy, Component, Inject } from '@angular/core';
 import { TranslocoPipe } from '@ngneat/transloco';
 import { MatDivider } from '@angular/material/divider';
 
-import { CHANGELOG } from './changelog';
+import { CHANGELOG_TOKEN, IChangelog } from './i-changelog';
 
 @Component({
     standalone: true,
@@ -16,5 +16,8 @@ import { CHANGELOG } from './changelog';
     changeDetection: ChangeDetectionStrategy.OnPush
 })
 export class ChangelogComponent {
-    public readonly log = CHANGELOG;
+    constructor(
+        @Inject(CHANGELOG_TOKEN) public readonly changelog: IChangelog
+    ) {
+    }
 }
diff --git a/modules/shared/ui/src/lib/changelog/i-changelog.ts b/modules/shared/ui/src/lib/changelog/i-changelog.ts
@@ -0,0 +1,8 @@
+import { InjectionToken } from '@angular/core';
+
+export interface IChangelog extends Array<{
+    version: string;
+    changeL10nKeys: Array<string>;
+}> { }
+
+export const CHANGELOG_TOKEN = new InjectionToken<IChangelog>('CHANGELOG');
diff --git a/modules/shared/ui/src/lib/changelog/index.ts b/modules/shared/ui/src/lib/changelog/index.ts
@@ -1 +1,2 @@
 export * from './changelog.component';
+export * from './i-changelog';
diff --git a/.../shared/ui/src/lib/changelog/changelog.ts → src/changelog.ts b/.../shared/ui/src/lib/changelog/changelog.ts → src/changelog.ts
@@ -1,18 +1,6 @@
-export type Changelog = Array<{
-    version: string;
-    changeL10nKeys: Array<string>;
-}>;
+import { IChangelog } from '@app/shared-ui';
 
-export const CHANGELOG: Changelog = [
-    {
-        version: '1.2.6',
-        changeL10nKeys: [
-            'changelog.1-2-6.fixServoCalibrationForRangesGraterThan360',
-            'changelog.1-2-6.fixServoCalibrationResultsNotBeingRound',
-            'changelog.1-2-6.fixMultipleServoCalibrationOnStartup',
-            'changelog.1-2-6.featMotorStrainingReduction',
-        ]
-    },
+export const CHANGELOG: IChangelog = [
     {
         version: '1.2.5',
         changeL10nKeys: [

diff --git a/src/main.ts b/src/main.ts
@@ -11,9 +11,11 @@ import { ShowOnTouchedErrorStateMatcher } from '@app/shared-misc';
 import { provideI18n } from '@app/shared-i18n';
 import { provideApplicationStore } from '@app/store';
 import { provideBindings } from '@app/bindings';
+import { CHANGELOG_TOKEN } from '@app/shared-ui';
 
 import { RootComponent } from './app';
 import { ROUTES } from './routes';
+import { CHANGELOG } from './changelog';
 
 bootstrapApplication(RootComponent, {
     providers: [
@@ -29,6 +31,7 @@ bootstrapApplication(RootComponent, {
         provideServiceWorker('ngsw-worker.js', {
             enabled: !isDevMode(),
             registrationStrategy: 'registerWhenStable:30000'
-        })
+        }),
+        { provide: CHANGELOG_TOKEN, useValue: CHANGELOG }
     ]
 });