Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[actions] update action versions to use node 20 #3299

Merged
merged 1 commit into from
Feb 19, 2024
Merged

[actions] update action versions to use node 20 #3299

merged 1 commit into from
Feb 19, 2024

Conversation

boidolr
Copy link
Contributor

@boidolr boidolr commented Feb 18, 2024

@boidolr boidolr changed the title chore: Update actions for node20 chore: Update actions for node20 on GH runners Feb 18, 2024
@ljharb
Copy link
Member

ljharb commented Feb 18, 2024

Thanks! Can we also update the harden runner to v2?

@ljharb ljharb marked this pull request as draft February 19, 2024 07:15
@boidolr
Copy link
Contributor Author

boidolr commented Feb 19, 2024

Sure, though it seems to handle sudo slightly differently: https://github.com/step-security/harden-runner/releases/tag/v2.0.0 I hope thats not an issue for you.

Any idea what the problem with the WSL runners is about?

@ljharb
Copy link
Member

ljharb commented Feb 19, 2024

that's fine, we don't need sudo disabled.

Any idea what the problem with the WSL runners is about?

yup, that's some kind of bug in WSL's own distribution that makes it fail to install from GHA; they're aware of it but haven't made progress in many months.

@ljharb ljharb changed the title chore: Update actions for node20 on GH runners [actions] update action versions to use node 20 Feb 19, 2024
@ljharb ljharb marked this pull request as ready for review February 19, 2024 19:18
@boidolr
Copy link
Contributor Author

boidolr commented Feb 19, 2024

Looks like https://github.com/nvm-sh/nvm/actions/runs/7964116887/job/21741033330?pr=3299 is trying to install an image from aws, which is blocked by the hardened runner as well.

@ljharb ljharb merged commit c24c313 into nvm-sh:master Feb 19, 2024
93 of 109 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants