Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: enhanced help documentation #3201

Closed
wants to merge 1 commit into from
Closed

Conversation

xgqfrms
Copy link

@xgqfrms xgqfrms commented Sep 21, 2023

Provide a more convenient solution that can using the nvm immediately.

demo

$ curl -o- https://raw.githubusercontent.com/nvm-sh/nvm/v0.39.5/install.sh | bash

# NVM_PROFILE
$ source /home/eric/.bashrc

image

@@ -456,7 +456,7 @@ nvm_do_install() {

nvm_reset

nvm_echo "=> Close and reopen your terminal to start using nvm or run the following to use it now:"
nvm_echo "=> Close and reopen your terminal to start using nvm or run the command \`source ${NVM_PROFILE}\` or run the following to use it now:"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's far better to have the user close and reopen the terminal, because that way they can test the lines in their profile file.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do not think so. The changes just now only provide more choices, and it is still up to the user to decide which solution to use.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't want the user to decide - I want the user to close and reopen their terminal, so they can test the lines in their profile file.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

=> Appending nvm source string to /home/eric/.bashrc
=> Appending bash_completion source string to /home/eric/.bashrc

Moreover, the configuration command has been injected into the configuration file, why do I need to add it manually? That makes no sense.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You shouldn’t need to add it manually, the install script adds it for you.

@xgqfrms
Copy link
Author

xgqfrms commented Sep 21, 2023

Alright, no need pay more attention.

@xgqfrms xgqfrms closed this Sep 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants