fix: finder filter functions should work on items inside of result table rather than the result table as a whole #1404
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR should fix #1394. Below is the example in the docs for filtering in the finder. Since it's specified that func should return a bool, I think the func is meant to be called on each element of the
result
table rather than theresult
table itself (which itself is just part of the map returned byvim.lsp.buf_request_all()
; the reuse of names is confusing). This way, I think it's more like the user can write filters that act on the finder results. Correct me if I'm wrong.Additionally,
fn()
inbox.filter
should also takeclient_id
so that filters are applied properly.If all looks good, I can clean up comments and/or change the name of
result_member
variable to something else.