open finder reference in the calling window #1283
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a small convenience improvement. Currently, when the finder uses
a normal layout with sp_global, the reference is always open
('toggle_or_open') in the leftmost window. This is quite inconvenient
when working with multiple vertical splits. Imagine that you search for
reference in the right split, and then the reference is open in the left
split, which has a completely different context.
When the finder is open, we memorize the current window id. When the
reference is opened, we use that window id instead of 0 (which by this
time is already the leftmost).
For float layout, or normal with sp_global=false, there is no change in
behavior.
|
sorry for late . should check layout ? looks like only useful on float right ? |
|
No, this is useful only in normal layout with sp_global=true. In this case, the finder reference will be open in the window from which the finder was started. In all other use cases, there is no change in behavior. |
Dosx001
pushed a commit
to Dosx001/lspsaga.nvim
that referenced
this pull request
Nov 18, 2023
This is a small convenience improvement. Currently, when the finder uses
a normal layout with sp_global, the reference is always open
('toggle_or_open') in the leftmost window. This is quite inconvenient
when working with multiple vertical splits. Imagine that you search for
reference in the right split, and then the reference is open in the left
split, which has a completely different context.
When the finder is open, we memorize the current window id. When the
reference is opened, we use that window id instead of 0 (which by this
time is already the leftmost).
For float layout, or normal with sp_global=false, there is no change in
behavior.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a small convenience improvement. Currently, when the finder uses a normal layout with sp_global, the reference is always open ('toggle_or_open') in the leftmost window. This is quite inconvenient when working with multiple vertical splits. Imagine that you search for reference in the right split, and then the reference is open in the left split, which has a completely different context.
When the finder is open, we memorize the current window id. When the reference is opened, we use that window id instead of 0 (which by this time is already the leftmost).
For float layout, or normal with sp_global=false, there is no change in behavior.