fix: incorrect cursor movement when splitkeep=topline
#155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
refactor: don't expose internal resize functions
|
Hmm nevermind, this did not fix it. Would recommend just using I'll keep looking into this though. |
|
Also see this issue upstream for more detail, it seems related: |
|
Should we document |
|
Yeah that might be a good idea, at least until there's a fix. |
|
Thanks for the collaborator invite @cryptomilk! Btw I noticed that we already have a notice in the readme about |
|
I think we should mention the cursor :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When
splitkeep=topline, resizing windows while moving between them can cause the cursor to jump / end up in the wrong position.vim.schedule-ing the resize functions seems to fix this for me.Also removed the use of
nvim_win_get_option.