fix: save and restore fixed win dimensions on resize #136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
willothy
force-pushed
the
fix-restore-fixed-wins
branch
from
4ea216b to
ef9daa2
Compare
|
Loogs good, thanks! |
|
Awesome! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is occasionally some flicker when switching windows, when some windows sizes are fixed (neo-tree, edgy.nvim, etc.), as Focus tries to resize them even if they are disabled when a neighboring window is resized.
This PR addresses this issue by saving and restoring the window dimensions of all disabled windows when resizing, ensuring that the layout stays consistent.
This makes a huge difference in some cases, and pretty much eliminates flickering entirely. It also solves the issue (#114) of windows being resized by their neighbors when they shouldn't be (without using
vim.fn.winlayout()!), allowing for more predictable resize behavior overall.closes #114